fix(alpha): add missing chainId to inference transaction in _send_tx_with_revert_handling#217
Open
amathxbt wants to merge 2 commits intoOpenGradient:mainfrom
Open
Conversation
All other build_transaction() calls in alpha.py include chainId, but _send_tx_with_revert_handling (used by infer()) was missing it. Without chainId, web3.py signs transactions without EIP-155 replay protection, causing them to be rejected on OpenGradient's network.
Adds TestAlphaInferenceChainId.test_send_tx_includes_chain_id to guard against regression of the missing chainId bug in _send_tx_with_revert_handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
builds a transaction without :
This is the helper that backs **** — the primary on-chain model inference call. Without :
Every other call in already includes :
Fix
Add the missing field to the one place it was omitted:
Test
Added in to assert that is present in the transaction parameters and matches .
Verification