fix: RegistryTEEConnection.reconnect() silently swallows _connect() failures#218
Open
amathxbt wants to merge 2 commits intoOpenGradient:mainfrom
Open
fix: RegistryTEEConnection.reconnect() silently swallows _connect() failures#218amathxbt wants to merge 2 commits intoOpenGradient:mainfrom
amathxbt wants to merge 2 commits intoOpenGradient:mainfrom
Conversation
…swallows_close_failure
Contributor
Author
|
@adambalogh can you take quick action is something critical |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Critical Bug: Silent TEE Failover Failure
File:
src/opengradient/client/tee_connection.py—RegistryTEEConnection.reconnect()What's broken
The
try/except Exceptionblock inreconnect()accidentally wraps the entire body includingself._active = self._connect(). If_connect()raises (registry down, no active TEE, TLS error), the exception is silently swallowed at DEBUG level andself._activeis never updated.The except was intended to guard old-client cleanup (matching
StaticTEEConnection), not the reconnect itself.Before (buggy):
After (fixed):
Impact
self._activestays stale pointing to dead connectionself._activeonly updated on successVerification
Matches the pattern already used correctly in
StaticTEEConnection.reconnect()(L78–L85).