fix: validate model string format before splitting in LLM methods#224
Open
crazywriter1 wants to merge 1 commit intoOpenGradient:mainfrom
Open
fix: validate model string format before splitting in LLM methods#224crazywriter1 wants to merge 1 commit intoOpenGradient:mainfrom
crazywriter1 wants to merge 1 commit intoOpenGradient:mainfrom
Conversation
…) and LLM.chat()
model.split('/')[1] raises IndexError when the model string has no slash.
Add an explicit check and raise ValueError with a helpful message instead.
Signed-off-by: crazywriter1 <crazywriter1@users.noreply.github.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLM.completion()andLLM.chat()callmodel.split("/")[1]to extract the model ID, which raises an unhandledIndexErrorif the string has no/separatorValueErrorwith a helpful message (e.g.expected 'provider/model') before the splitValueErrorcompletion()andchat()Test plan
test_completion_rejects_model_without_slashtest_completion_rejects_model_with_trailing_slashtest_chat_rejects_model_without_slashclient_test.pypass