fix: use httpx context manager and align transaction_hash in Twins.chat()#225
Open
crazywriter1 wants to merge 1 commit intoOpenGradient:mainfrom
Open
fix: use httpx context manager and align transaction_hash in Twins.chat()#225crazywriter1 wants to merge 1 commit intoOpenGradient:mainfrom
crazywriter1 wants to merge 1 commit intoOpenGradient:mainfrom
Conversation
Author
…ternal' in Twins.chat() httpx.post() was called without a context manager, leaving connections unclosed. transaction_hash was set to empty string instead of 'external' used by LLM class. Signed-off-by: crazywriter1 <crazywriter1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Twins.chat()calledhttpx.post()directly without a context manager, leaving the underlying TCP connection unclosed after each request. Wrapped the HTTP call inhttpx.Client()context manager to ensure proper cleanup.transaction_hashwas set to an empty string"", whileLLM.completion()andLLM.chat()both use"external"for non-blockchain responses. Aligned to"external"for consistency across the SDK.Test plan
test_chat_uses_context_manager— verifies__enter__and__exit__are calledtest_chat_returns_external_transaction_hash— assertstransaction_hash == "external"test_chat_empty_choices_raises— confirmsRuntimeErroron empty choicesclient_test.pypass