Move most raster layers to MaplibreGL & remove dead code#297
Move most raster layers to MaplibreGL & remove dead code#297ZeLonewolf wants to merge 3 commits intoOpenHistoricalMap:stagingfrom
Conversation
|
|
||
| .toggleClass("btn-primary", true) | ||
| .toggleClass("btn-secondary", false) | ||
| .tooltip(true ? "disable" : "enable"); |
There was a problem hiding this comment.
This will always resolve to "disable". The ternary is apparently unnecessary because we don’t feature the Tracestrack Topo layer, but will this be a source of conflicts with upstream?
| style: { | ||
| version: 8, | ||
| sources: { | ||
| 'cyclosm': { |
There was a problem hiding this comment.
Nit: This part of the diff is somewhat inconsistent in its use of single versus double quotation marks.
There was a problem hiding this comment.
This is like this because the file I pulled it in from was using single quotes. Should I just change them to be consistent through?
There was a problem hiding this comment.
Yeah, might as well to be internally consistent.
Co-authored-by: Minh Nguyễn <mxn@1ec5.org>
|
@erictheise is going to look at this as soon as we do an upstream catchup, expected today. Then we'll look at this relative to that newer code from upstream |
|
#316 eliminated some of the custom maplibre-gl-leaflet integration code in favor of what openstreetmap-website did upstream in openstreetmap#6137. It’s cleaner and more reliable, though there’s some additional code to clean up around how the time slider hooks in. This refactoring conflicts with your PR, but it looks like most of the changes are effectively merged already. The one thing that hasn’t landed is the commented-out option to specify a Tracestrack API key. |
4 participants
Initial incremental step towards OpenHistoricalMap/ohm-website#651
Description
This PR moves most of the raster layers to MapLibre GL and removes associated dead code that I discovered during the process. I'm leaving the standard tile layer for now because it's hooked into a few other places that seemed more complicated to handle.
How has this been tested?
Tested locally, appears to look identically between localhost and openhistoricalmap.org.