Switching to avoid leading zeros in future memberID creations#1150
Open
danamlewis wants to merge 1 commit intoOpenHumans:masterfrom
Open
Switching to avoid leading zeros in future memberID creations#1150danamlewis wants to merge 1 commit intoOpenHumans:masterfrom
danamlewis wants to merge 1 commit intoOpenHumans:masterfrom
Conversation
Contributor
|
Why not switch to strings then? |
Contributor
Author
|
@abitrolly I would be happy with achieving the goal of removing the leading zeros in generate project memberID's with whatever way @madprime prefers. I wanted to generate a PR to get this initiative moving, since it's been bothering many project administrators for years. @madprime please let me know if there's anything else we can do to help move forward this or related solutions. Thanks! |
Member
|
The code looks good; I'm curious if this implies a secondary step to re-assign user IDs that currently have leading zeroes? If so, this code helps limit the number of reassignments that will happen if we do take that step in the future so it's worth merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously memberIDs could be created with 0 in the front. Various programs for data processing drop the 0, and then re-using the project memberIDs back in the command line would cause various errors in pulling or processing the data. Immense headaches have ensued for project administrators and data users. This attempts to remove the leading zeros (although it doesn't solve existing memberIDs with leading zeros) from future projectmemberID creation.
Testing
Have not tested but used OpenAI Codex to validate the sanity of this potential solution.