Updates Migrate4_5_2.java to allow for log4j2-cli.properties not being present #129
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Ogin <rogin@users.noreply.github.com>
rogin
force-pushed
the
fix-migration-4.5.2
branch
from
8ae1a66 to
c856702
Compare
kpalang
requested review from
a team,
kayyagari,
gibson9583,
ssrowe and
pacmano1
and removed request for
a team
pacmano1
requested changes
Sep 8, 2025
mgaffigan
requested changes
Sep 8, 2025
There was a problem hiding this comment.
This doesn't seem right: the file is in the setup conf directory, and this migration seems to be the dual of 249b900. UTF-8 is not the default for appender.console.layout.charset. How are we assuming the install got to this state?
Perhaps the file should be created if it is not present? At a minimum, I would presume a warning would be called for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds null check as property file may not exist.
To Reproduce: upgrade 4.5.1 to 4.5.2 without log4j2-cli.properties in the /conf directory
Related
nextgenhealthcare/connect#6327
Summary table in #121