Skip to content

Fix warnings about deprecated constructors #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025

Conversation

mgaffigan
Copy link
Contributor

Fixes javac build warnings present on Java 8 and Java 17.

Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Copy link
Member

@tonygermano tonygermano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made several comments related to the auto-boxing commit. In general, where auto-boxing of primitives without casting is not enough, I would prefer to see the PrimitiveWrapper.valueOf() methods used over a cast. There are a few places where you have done it that way, and others where you have not.

I don't think we should make the security manager changes at this time. The security manager still works through java 23. According to https://openjdk.org/jeps/486, from java 24 on, it behaves as if a security manager is not installed, but the api methods have not yet been removed. Since we don't know who is currently using a security manager, I think we should not remove support for it without adequate warning. Obviously, if we eventually drop support for java versions < 24 there is no reason to keep it.

Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
@mgaffigan
Copy link
Contributor Author

I split #152 out to separately address java security manager.

@mgaffigan mgaffigan changed the title Fix warnings about deprecated constructors and java security manager Fix warnings about deprecated constructors Jul 29, 2025
@mgaffigan mgaffigan requested a review from tonygermano July 29, 2025 16:27
Copy link
Member

@tonygermano tonygermano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Changes all look good to me.

@tonygermano tonygermano requested review from a team, kayyagari, gibson9583, kpalang and jonbartels and removed request for a team July 30, 2025 00:27
Copy link
Contributor

@jonbartels jonbartels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific testing process we can use to observe these build warnings?

Just build it and read the output or is there a better way to filter through all the noise that ant spews out?

@mgaffigan
Copy link
Contributor Author

@jonbartels, I'm just reading ant output.

Once we get to zero (by fixing or if a warning is intractable by adding a suppression), I'd recommend turning on "warnings as errors" in the GitHub Action to avoid introducing new warnings in PRs. This also will make warnings introduced by version changes obvious (e.g. dependabot).

@kpalang kpalang merged commit 956c284 into OpenIntegrationEngine:main Aug 1, 2025
2 checks passed
@jonbartels jonbartels added this to the Next Release milestone Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants