Skip to content

Java 8u261 added support for TLS1.3, avoid assuming otherwise #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Java 8u261 added support for TLS1.3, avoid assuming otherwise #149

wants to merge 2 commits into from

Conversation

mgaffigan
Copy link
Contributor

Related #144

@mgaffigan
Java 8u261 added support for TLS1.3, avoid assuming otherwise
8920069 
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
tonygermano
tonygermano reviewed Jul 29, 2025
View reviewed changes
Copy link
Member

@tonygermano tonygermano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of the java version check and always assertTrue? I am not worried about the tests failing if they are run on a too old version of java 8 since we are working to completely remove java 8 support, anyway.

@mgaffigan
Remove version check since all supported java versions support tls1.3
ca21f1e 
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
@kpalang kpalang requested review from a team, kayyagari, gibson9583, kpalang and tonygermano and removed request for a team August 1, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayyagari kayyagari Awaiting requested review from kayyagari kayyagari was automatically assigned from OpenIntegrationEngine/maintainers

@gibson9583 gibson9583 Awaiting requested review from gibson9583 gibson9583 was automatically assigned from OpenIntegrationEngine/maintainers

@kpalang kpalang Awaiting requested review from kpalang kpalang was automatically assigned from OpenIntegrationEngine/maintainers

@tonygermano tonygermano Awaiting requested review from tonygermano tonygermano was automatically assigned from OpenIntegrationEngine/maintainers

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgaffigan @tonygermano