Login and client command line refactoring #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mgaffigan Is it possible to break this up into a few commits to make it easier to review? There is enough change that it's a bit difficult to mentally keep track of which changes are related to the same refactor and which aren't with all of the scrolling. |
mgaffigan
commented
Sep 3, 2025
|
@mgaffigan I'm fine with them all being part of this single PR. I was just asking if the logical chunks can be separated into multiple commits. |
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
|
Ah. Good call. Yes. I'll break to commits. |
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
…ying on global state Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
…tations Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
force-pushed
the
maint/refactor-client-login
branch
from
4229704 to
f9aad48
Compare
|
@tonygermano, not sure each commit builds in isolation, but I rewrote the history by topic. Let me know if you need anything further. |
kpalang
requested review from
a team,
kayyagari,
gibson9583,
kpalang and
tonygermano
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support for future merge of mgaffigan:feature/add-oidc-auth