Skip to content

Add script to automatically format code before merging PRs#394

Closed
Xeeynamo wants to merge 3 commits intomasterfrom
feature/format-code
Closed

Add script to automatically format code before merging PRs#394
Xeeynamo wants to merge 3 commits intomasterfrom
feature/format-code

Conversation

@Xeeynamo
Copy link
Contributor

I was planning this PR since months, but I never pushed it as I knew it would cause a major pain at rebasing and merging. But as lately more and more people are forking and making changes to the project, I can not really delay this any further.

This PR adds an Action that automatically creates commits that formats the code based on the specifications in the .editorconfig. The commits that fixes the formatting will look like this.

@Xeeynamo Xeeynamo force-pushed the feature/format-code branch from 8eb4d64 to 4d7434f Compare January 25, 2021 17:08
@Xeeynamo Xeeynamo force-pushed the feature/format-code branch 2 times, most recently from 0fe25e0 to a40e46d Compare January 26, 2021 00:06
@Xeeynamo Xeeynamo marked this pull request as draft January 26, 2021 00:08
@ghost ghost added the Enhancement Request for, or a pull request of, a new feature or enhancement to an existing one. label Jan 26, 2021
@Xeeynamo Xeeynamo force-pushed the feature/format-code branch from a5ccc03 to dfbffc2 Compare March 28, 2021 12:09
@Xeeynamo Xeeynamo marked this pull request as ready for review March 28, 2021 12:10
@Xeeynamo
Copy link
Contributor Author

I am marking this PR as ready to be reviewed. There are no many reasons to hold this back any longer.

I highly suggest to merge this only after #457 , #416 and #458 to avoid conflicts.

@Xeeynamo Xeeynamo force-pushed the feature/format-code branch from e7cf9eb to 033273b Compare March 28, 2021 12:29
@Vladabdf
Copy link
Collaborator

Vladabdf commented Jan 3, 2023

Closing, but the branch will remain in the event this is actually useful and can be cleaned and merged later on if necessary. (It seems pedantic to me.)

@Vladabdf Vladabdf closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Request for, or a pull request of, a new feature or enhancement to an existing one.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants