Fix footer on home route & add social links#141
Fix footer on home route & add social links#141gmarav05 wants to merge 1 commit intoOpenLake:mainfrom
Conversation
|
@gmarav05 is attempting to deploy a commit to the aviralsaxena16's projects Team on Vercel. A member of the Team first needs to authorize it. |
🎉 Thanks for Your Contribution to CanonForces!
|
WalkthroughPackage dependencies updated to exact versions and React's automatic JSX runtime enabled. The Footer component gains clickable social media links, updated copyright year, and a typo fix. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/common/components/Footer/Footer.tsx`:
- Around line 55-62: Update the placeholder Facebook anchor in Footer.tsx:
replace the href value on the anchor with the correct OpenLake Facebook page URL
(use the org's canonical Facebook URL), ensure the anchor with
aria-label="Facebook" wraps the BsFacebook icon, and fix indentation to match
the other social links (Twitter/LinkedIn/Instagram) so attributes and the
closing </a> align consistently.
🧹 Nitpick comments (2)
package.json (1)
48-50: Inconsistent version pinning strategy for React types.
@types/reactis pinned to an exact version (19.2.10) while@types/react-domat line 50 still uses a caret range (^19.2.2). These packages should stay in sync to avoid type mismatches. Consider applying the same pinning strategy to both.Proposed fix
"@types/node": "24.10.9", "@types/react": "19.2.10", - "@types/react-dom": "^19.2.2", + "@types/react-dom": "19.2.10",src/common/components/Footer/Footer.tsx (1)
69-69: Consider using a dynamic year to avoid future maintenance.Hardcoding the year means it will become outdated again. Using
new Date().getFullYear()ensures it's always current.Proposed fix
<div className={styles.footer__rights}> - <h3> `@2026` Canonforces Pvt. Ltd. All Rights Reserved </h3> + <h3> @{new Date().getFullYear()} Canonforces Pvt. Ltd. All Rights Reserved </h3> </div>
| <a | ||
| href="https://www.facebook.com" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| aria-label="Facebook" | ||
| > | ||
| <BsFacebook size="1.5em" /> | ||
| </a> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n src/common/components/Footer/Footer.tsx | sed -n '28,63p'Repository: OpenLake/canonforces
Length of output: 1336
🌐 Web query:
OpenLake IIT Bhilai Facebook page
💡 Result:
I couldn’t find any public/official Facebook page for OpenLake (IIT Bhilai) via web search. The public official presence I could verify is:
- Official site (FOSS Overflow): (fossoverflow.openlake.in)
- OpenLake IIT Bhilai X (Twitter) handle: (twstalker.com)
- OpenLake page on IIT Bhilai Sci-Tech Council site: (scitech-iitbh.github.io)
If you still want to check Facebook directly, try this Facebook search:
https://www.facebook.com/search/pages?q=OpenLake%20IIT%20BhilaiCitations:
- 1: https://fossoverflow.openlake.in/?utm_source=openai
- 2: https://www.twstalker.com/OpenLakeClub?utm_source=openai
- 3: https://scitech-iitbh.github.io/scitech-iitbhilai/Openlake.html?utm_source=openai
Facebook link appears to be a placeholder with inconsistent indentation.
The Facebook link points to the generic https://www.facebook.com instead of a specific organization page like the other social links. Additionally, the anchor tag attributes and closing tag have inconsistent indentation compared to the Twitter, LinkedIn, and Instagram links above it.
Proposed fix
<a
- href="https://www.facebook.com"
+ href="https://www.facebook.com/[correct-page]"
target="_blank"
rel="noopener noreferrer"
aria-label="Facebook"
>
<BsFacebook size="1.5em" />
- </a>
+ </a>Determine the correct OpenLake Facebook page URL and update accordingly to match the pattern of other social links.
🤖 Prompt for AI Agents
In `@src/common/components/Footer/Footer.tsx` around lines 55 - 62, Update the
placeholder Facebook anchor in Footer.tsx: replace the href value on the anchor
with the correct OpenLake Facebook page URL (use the org's canonical Facebook
URL), ensure the anchor with aria-label="Facebook" wraps the BsFacebook icon,
and fix indentation to match the other social links (Twitter/LinkedIn/Instagram)
so attributes and the closing </a> align consistently.
aviralsaxena16
left a comment
aviralsaxena16
left a comment
There was a problem hiding this comment.
Thanks for the contribution @gmarav05 , I will review it soon
2 participants
name: "📦 Pull Request"
about: Submit changes for review
title: "PR: fixes footer on home route & add social links"
labels: ""
assignees: ""
📌 Related Issue
✨ Changes Introduced
🤔 Why This Change?
🖼️ Screenshots / Loom Video (if applicable)
🧪 Testing
npm test)npm run test:integration)📝 Documentation Updates
✅ Checklist
👥 Reviewers
🚀 Deployment Notes
💬 Community & Support
Need help or want to discuss this PR?
Join our Discord community 👉 CanonForces Discord
💡 Additional Notes (If any)
Summary by CodeRabbit
New Features
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.