Conversation
…sensors, articulated objects, data assets, and tags
…il generation in URDF gallery)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a substantial overhaul of the URDF Studio application, focusing on a more robust and user-friendly experience. Key areas of improvement include a new history management system for undo/redo, refined collision body manipulation, and a comprehensive UI/UX refresh. The underlying parsing and generation logic for URDF and MJCF have been upgraded, and the project file format has been extended to ensure a more complete and reliable saving of workspace states. Highlights
Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request delivers a substantial refactoring of the application's state management, particularly focusing on history and property updates. Key improvements include a debounced history system, which enhances robustness, and significant UI/UX upgrades in the property editor with new, more interactive form controls. Performance is also boosted through incremental updates to the robot model, avoiding full reloads on minor changes. While the changes are extensive, they represent a major step forward in the application's architecture and user experience. My only concern is a change that reduces the precision of geometry dimension adjustments, which might impact fine-tuning of models.
| @@ -1,5 +1,5 @@ | |||
| export const MAX_GEOMETRY_DIMENSION_DECIMALS = 5; | |||
| export const GEOMETRY_DIMENSION_STEP = 0.00001; | |||
| export const GEOMETRY_DIMENSION_STEP = 0.01; | |||
There was a problem hiding this comment.
The step for geometry dimensions has been increased significantly from 0.00001 to 0.01. This makes the stepper controls much coarser, which could negatively impact users who need to make fine-tuned adjustments to their models. While a larger step can speed up rough adjustments, this 1000x increase might be too aggressive. Consider using a smaller value, like 0.001, as a compromise between ease of use and precision.
Suggested change
| export const GEOMETRY_DIMENSION_STEP = 0.01; | |
| export const GEOMETRY_DIMENSION_STEP = 0.001; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.