-
Notifications
You must be signed in to change notification settings - Fork 3
Sim fine tune #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sim fine tune #112
Conversation
…iles to use sim params if use_sim is true
* Override param * Improve parameters overwritten
go2_sdk/config/nav2_params_sim.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this
|
|
||
| # Add go2_description/models to GZ_SIM_RESOURCE_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Add go2_description/models to GZ_SIM_RESOURCE_PATH |
|
|
||
| # Ensure GZ_SIM_RESOURCE_PATH includes the models directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Ensure GZ_SIM_RESOURCE_PATH includes the models directory |
|
|
||
| # Spawn ArUco Marker | ||
| # We use the absolute path to the model.sdf to avoid model:// URI resolution issues | ||
| aruco_model_path = os.path.join(go2_description, "models/aruco_marker/model.sdf") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move it to the top
go2_sdk/config/nav2_params.yaml
Outdated
| resolution: 0.05 | ||
| footprint: "[[0.3, 0.2], [0.3, -0.2], [-0.3, -0.2], [-0.3, 0.2]]" | ||
| transform_tolerance: 1.0 | ||
| # Slightly smaller footprint to prevent self-collision in costmap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this
go2_sdk/config/nav2_params.yaml
Outdated
| use_sim_time: False | ||
| footprint: "[[0.3, 0.2], [0.3, -0.2], [-0.3, -0.2], [-0.3, 0.2]]" | ||
| transform_tolerance: 1.0 | ||
| # Slightly smaller footprint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the Go2 robot simulation by adding ArUco marker support for docking, switching to a new world environment, and extensively tuning navigation parameters for improved performance. The changes introduce simulation-specific parameter overrides to optimize behavior in simulation while maintaining separate configurations for real hardware deployment.
- Added ArUco marker model for docking simulation
- Switched default world from
maze_world.sdftohome_world.sdf - Implemented simulation-specific navigation parameter overrides in launch files
- Tuned navigation stack parameters for better path following and obstacle avoidance
- Increased gait velocity limits for faster simulated movement
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| go2_sdk/launch/slam_launch.py | Added simulation parameter override system with tuned controller, planner, and velocity smoother settings |
| go2_sdk/launch/nav2_launch.py | Implemented identical simulation override mechanism for navigation launch |
| go2_sdk/config/nav2_params_sim.yaml | New comprehensive simulation-specific navigation configuration file |
| go2_sdk/config/nav2_params.yaml | Updated base navigation parameters with adjusted tolerances, velocities, and critic weights |
| go2_gazebo_sim/go2_gazebo_sim/launch/go2_launch.py | Changed default world, added ArUco marker spawning, and configured Gazebo resource paths |
| go2_gazebo_sim/go2_gazebo_sim/config/gait/gait.yaml | Increased maximum linear and angular velocity limits |
| go2_gazebo_sim/go2_description/models/aruco_marker/model.sdf | ArUco marker model definition for simulation |
| go2_gazebo_sim/go2_description/models/aruco_marker/model.config | ArUco marker metadata configuration |
| go2_gazebo_sim/go2_description/CMakeLists.txt | Added installation rules for models and tags directories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
go2_sdk/launch/slam_launch.py
Outdated
| "inflation_layer.inflation_radius": 0.30, | ||
| }, | ||
| "planner_server": { | ||
| # globl costmap params |
Copilot
AI
Dec 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'globl' to 'global'.
| # globl costmap params | |
| # global costmap params |
go2_sdk/launch/nav2_launch.py
Outdated
| "inflation_layer.inflation_radius": 0.30, | ||
| }, | ||
| "planner_server": { | ||
| # globl costmap params |
Copilot
AI
Dec 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'globl' to 'global'.
| # globl costmap params | |
| # global costmap params |
| install(DIRECTORY | ||
| models | ||
| DESTINATION | ||
| share/${PROJECT_NAME}) |
Copilot
AI
Dec 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The models directory is installed twice (lines 29-32 and 34-37). Remove the duplicate installation directive to avoid redundancy.
| install(DIRECTORY | |
| models | |
| DESTINATION | |
| share/${PROJECT_NAME}) |
…ic battery drain and `/lf/lowstate` publishing.
| """ | ||
| A ROS2 node that publishes mock LowState messages for Unitree Go2 simulation. | ||
| This provides simulated robot state data including IMU, motor, and battery information. | ||
| Battery simulation auto-detects movement from cmd_vel for realistic drain behavior. | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this
|
|
||
| # Add go2_description/models to GZ_SIM_RESOURCE_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Add go2_description/models to GZ_SIM_RESOURCE_PATH |
…e functionality with lowstate
This pull request introduces several important updates to the simulation and navigation stack for the Go2 robot. The main changes include adding an ArUco marker model to the simulation, updating the launch process to include this marker, and extensive tuning of navigation and gait parameters for improved robot performance and simulation fidelity.
Simulation and Launch Enhancements:
aruco_markermodel (withmodel.sdfandmodel.config) for use as a docking target in simulation. The marker includes a visual texture and is placed in the simulation world. [1] [2]go2_launch.py) to:GZ_SIM_RESOURCE_PATHenvironment variable so Gazebo can find custom models.maze_world.sdftohome_world.sdf. [1] [2] [3] [4]modelsandtagsdirectories are installed with the package, making custom assets available in deployments.Navigation Parameter Tuning:
nav2_params.yaml:Gait and Motion Constraints:
Simulation and Asset Management:
model.sdf,model.config) and ensured their installation and availability in Gazebo simulation. [1] [2] [3]Navigation Stack Tuning:
Gait Configuration: