Skip to content

[ModelicaSystem] do NOT store data in the class workspace #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adeas31 merged 3 commits into from
Apr 23, 2025
Merged

[ModelicaSystem] do NOT store data in the class workspace #252

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da9deba
[ModelicaSystem] do NOT store data in the class workspace
syntron Apr 15, 2025
1393f80
Merge remote-tracking branch 'origin' into fix_xmlparse
adeas31 Apr 23, 2025
4841e4e
Merge branch 'master' into fix_xmlparse
adeas31 Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions OMPython/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,6 @@ def __init__(self, fileName=None, modelName=None, lmodel=None, commandLineOption
if fileName is None and modelName is None and not lmodel: # all None
raise Exception("Cannot create ModelicaSystem object without any arguments")

self.tree = None
self.quantitiesList = []
self.paramlist = {}
self.inputlist = {}
Expand Down Expand Up @@ -842,9 +841,8 @@ def xmlparse(self):
self._raise_error(errstr=f"XML file not generated: {self.xmlFile}")
return

self.tree = ET.parse(self.xmlFile)
self.root = self.tree.getroot()
rootCQ = self.root
tree = ET.parse(self.xmlFile)
rootCQ = tree.getroot()
for attr in rootCQ.iter('DefaultExperiment'):
for key in ("startTime", "stopTime", "stepSize", "tolerance",
"solver", "outputFormat"):
Expand Down
Loading