Conversation
indigo423
changed the title
indigo423
force-pushed
the
ronny/JICMP-27
branch
3 times, most recently
from
8684033 to
abdfb07
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the JICMP build configuration to compile with OpenJDK 17, replacing the deprecated javah tool with the modern javac -h approach introduced in JEP 313.
Changes:
- Migrated from
javahtojavac -hfor native header generation - Updated minimum Java version from 1.8 to 17 across build files and documentation
- Updated Maven plugin versions and CI/CD configurations to support Java 17
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml.in | Updated Maven plugins, changed from source/target to release flag, updated execution environment to JavaSE-17 |
| m4 | Updated submodule commit reference |
| docs-src/modules/installation/pages/source.adoc | Updated documentation to specify Java JDK 17 requirement |
| configure.ac | Updated JDK check to version 17, removed JAVAH variable reference |
| README.adoc | Updated Java JDK requirement to version 17 |
| Makefile.am | Replaced javah with javac -h flag, updated javac compilation flags |
| .circleci/config.yml | Updated CI environment images and JDK versions to OpenJDK 17, updated Debian version to bookworm |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
indigo423
force-pushed
the
ronny/JICMP-27
branch
5 times, most recently
from
9aedfcf to
c247125
Compare
Migrate javah to javac -h to compile with modern JDK. The javah tool to generate native-headers is removed in OpenJDK 10+ and replaced with javac -h. See JEP 313. Signed-off-by: Ronny Trommer <ronny@no42.org>
Signed-off-by: Ronny Trommer <ronny@no42.org>
Signed-off-by: Ronny Trommer <ronny@no42.org>
Signed-off-by: Ronny Trommer <ronny@no42.org>
Signed-off-by: Ronny Trommer <ronny@no42.org>
Signed-off-by: Ronny Trommer <ronny@no42.org>
Signed-off-by: Ronny Trommer <ronny@no42.org>
indigo423
force-pushed
the
ronny/JICMP-27
branch
from
c247125 to
a410ade
Compare
Signed-off-by: Ronny Trommer <ronny@no42.org>
indigo423
force-pushed
the
ronny/JICMP-27
branch
from
a410ade to
781dd5b
Compare
Signed-off-by: Ronny Trommer <ronny@no42.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate javah to javac -h to compile with modern JDK. The javah tool to generate native-headers is removed in OpenJDK 10+ and replaced with javac -h. See JEP 313.
JIRA: https://opennms.atlassian.net/browse/JICMP-27