Skip to content

NMS-19448: Trapd Config to DB: Migrate trapd-configuration.xml to CM#8274

Open
christianpape wants to merge 6 commits intodevelopfrom
jira/NMS-19448
Open

NMS-19448: Trapd Config to DB: Migrate trapd-configuration.xml to CM#8274
christianpape wants to merge 6 commits intodevelopfrom
jira/NMS-19448

Conversation

@christianpape
Copy link
Contributor

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates trapd configuration from XML file-based configuration to the Configuration Management (CM) system in the database, supporting the broader effort to centralize configuration management.

Changes:

  • Introduced TrapdConfigDao and DefaultTrapdConfigDao to manage trapd configuration through CM
  • Refactored TrapdConfigFactory to use DAO instead of direct file reading
  • Added test infrastructure with NullEventForwarder and updated test contexts across the codebase

Reviewed changes

Copilot reviewed 109 out of 109 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
opennms-dao-api/src/main/java/org/opennms/netmgt/dao/api/TrapdConfigDao.java Defines DAO interface for trapd configuration
opennms-dao/src/main/java/org/opennms/netmgt/dao/jaxb/DefaultTrapdConfigDao.java Implements DAO using CM service
opennms-config/src/main/java/org/opennms/netmgt/config/TrapdConfigFactory.java Refactored to use DAO instead of file reading
opennms-config-jaxb/src/main/java/org/opennms/netmgt/config/trapd/TrapdConfiguration.java Updated field naming from underscore prefix to camelCase
opennms-config-jaxb/src/main/java/org/opennms/netmgt/config/trapd/Snmpv3User.java Updated field naming from underscore prefix to camelCase
core/test-api/services/src/main/java/org/opennms/netmgt/config/mock/NullEventForwarder.java Added test mock for EventForwarder
features/config/upgrade/src/main/resources/changelog-cm/36.0.0/changelog-cm.xml Added CM schema registration for trapd configuration
opennms-dao/src/main/resources/META-INF/opennms/applicationContext-dao.xml Registered trapd DAO beans and services
Multiple test files Updated test contexts to include nullEventForwarder configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

christianpape and others added 2 commits February 4, 2026 10:05
…s/netmgt/threshd/CollectionResourceWrapperIT.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/EventUtilIT.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant