Skip to content

B #-: Fixes onegate requests adding content-type header #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rsmontero merged 1 commit into from
Apr 23, 2025
Merged

B #-: Fixes onegate requests adding content-type header #233

rsmontero merged 1 commit into from
Apr 23, 2025

Conversation

@aleixrm
Copy link
Member

@aleixrm aleixrm commented Apr 22, 2025

  • Adds Content-type: application/json header to onegate requests for fixing them.
  • Removes curl and wget as fallback methods for reporting readiness to onegate (unify interface to onegate client).

@aleixrm
B #-: Fixes onegate requests adding content-type header
9d32d8a 
Signed-off-by: Aleix Ramírez <aramirez@opennebula.io>
@aleixrm aleixrm marked this pull request as ready for review April 23, 2025 14:41
sk4zuzu
sk4zuzu approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@sk4zuzu sk4zuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsmontero rsmontero merged commit fabec86 into master Apr 23, 2025
1 check passed
@rsmontero rsmontero deleted the b-#/fixes-onegate-requests-wo-context-type branch April 23, 2025 15:53
aleixrm added a commit that referenced this pull request Apr 24, 2025
@aleixrm
Revert "B #-: Fixes onegate requests adding content-type header (#233)"
65c88ce 
This reverts commit fabec86.
@aleixrm aleixrm mentioned this pull request Apr 24, 2025
Merged
rsmontero pushed a commit that referenced this pull request Apr 24, 2025
@aleixrm
Revert "B #-: Fixes onegate requests adding content-type header (#233)…
ad91481 
…" (#236)

This reverts commit fabec86.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsmontero rsmontero rsmontero approved these changes

@jaimecb jaimecb Awaiting requested review from jaimecb

+1 more reviewer

@sk4zuzu sk4zuzu sk4zuzu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aleixrm @rsmontero @sk4zuzu