Avoid crash when selecting paced occurences in TOD #14816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu <mathieu.coulibaly@sncf.fr>
Caracol3
added
the
module:operational-studies
Contributor
|
I can't use the ticket timetable because I'm getting an error. Do you have a timetable that works? |
Contributor
Author
|
Yes, you can use this one with small infra |
Contributor
I get this error when I import |
Contributor
Author
|
Weird, have you rebuild recently ? |
Contributor
yes :/ |
emersion
reviewed
Jan 23, 2026
Member
emersion
left a comment
emersion
left a comment
There was a problem hiding this comment.
I'm confused:
- Only timetable items without a
pacedattribute and occurrences can be selected. Timetable items with apacedattribute cannot. Why are we getting one? - The train ID used for projection should have no impact on the ETCS braking curves displayed on the speed-space chart, I believe? (More generally, projection only applies to the time-space chart.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, selecting a paced train occurrence in the chart could emit a
paced_*id instead of an occurrence id. This caused the ETCS braking curves hook to crash because the endpoint expects anOccurrenceId. Now we normalize theidused for ETCS requests to an occurrence id (projection occurrence when available, otherwise occurrence index 0).close #14783