Sync timetable hover on train with space-time chart one #14850
+79
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caracol3
added
kind:enhancement
Caracol3
changed the title
Caracol3
force-pushed
the
mcy/operational-studies-hover-train-in-std-when-hovering-in-timetable
branch
from
9513702 to
d246925
Compare
achrafmohye
reviewed
Jan 23, 2026
| pathfindingHasFailed | ||
| ); | ||
|
|
||
| const hoveredPathId = useMemo(() => { |
Contributor
There was a problem hiding this comment.
nit: rename this constant now it relates to path ids and train ids ?
Contributor
Author
There was a problem hiding this comment.
Although the chart calls it pathId, it’s the same TrainId in our code, so i renamed it hoveredTrainIdForChart which is clearer and doesn’t suggest two ID types.
achrafmohye
approved these changes
Jan 23, 2026
Contributor
achrafmohye
left a comment
achrafmohye
left a comment
There was a problem hiding this comment.
LGTM and tested thanks
kmer2016
reviewed
Jan 23, 2026
| dragging: boolean, | ||
| selectedTrainId?: TrainId | ||
| selectedTrainId?: TrainId, | ||
| hoveredTrainId?: TrainId |
Contributor
There was a problem hiding this comment.
Nit: just to clarify the source of the hover.
Suggested change
| hoveredTrainId?: TrainId | |
| hoveredTrainIdFromTimetable?: TrainId |
kmer2016
approved these changes
Jan 23, 2026
Signed-off-by: Mathieu <mathieu.coulibaly@sncf.fr>
Caracol3
force-pushed
the
mcy/operational-studies-hover-train-in-std-when-hovering-in-timetable
branch
from
d246925 to
c3a0634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close https://github.com/osrd-project/osrd-confidential/issues/1225