Skip to content

add cell editing to new Times stops table #14853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
kmer2016 wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

add cell editing to new Times stops table #14853

kmer2016 wants to merge 5 commits into from
+746 −72

Conversation

@kmer2016
Copy link
Contributor

@kmer2016 kmer2016 commented Jan 23, 2026 •
edited
Loading

Closes #14282

Summary

  • Wire TimeCell to "Arrival Time" / "Heure d'arrivée", "Departure Time" / "Heure de départ" and "Stop Duration" / "Temps d'arrêt" columns
  • Cell updates are saved on onBlur event

See commits

Editable columns

  • Arrival Time / Heure d'arrivée (requestedArrival)
  • Departure Time / Heure de départ (requestedDeparture)
  • Stop Duration / Temps d'arrêt (stopDuration) : component ready, not yet wired

Test plan

  • Edit arrival time on a row ==> resimulation triggers, computed times update
  • Edit departure time on a row (not first row) ==> resimulation triggers
  • Edit departure time on first row ==> updates train start_time, all other times shift accordingly
  • Edit on a PacedTrain (simple train)
  • Edit on an occurrence (exception is created/updated)
  • Clear a time field ==> value is removed from schedule

@kmer2016
front: add locationsMatch utility for PathItemLocation
9fe8551 
Used to compare two PathItemLocation objects when editing cells
in the times/stops table.

Signed-off-by: nncluzu <ngamenichaka@yahoo.fr>
@kmer2016
front: extend TimesStopsRowNew with location and isPathStep
9252b67 
Add fields needed for cell editing:
- isPathStep: indicates if the row is a path step or just an OP
- location: stores the PathItemLocation for creating new path items

Signed-off-by: nncluzu <ngamenichaka@yahoo.fr>
@kmer2016
front: wire editable TimeCell to TimesStopsTable
720cbc9 
Signed-off-by: nncluzu <ngamenichaka@yahoo.fr>
@kmer2016
front: add useUpdateTimesStopsTable hook for cell edits
537a6bb 
Add hook to persist arrival/departure edits to the API and trigger
re-simulation. Supports TimetableItems and PacedTrain occurrences
with exception handling.

Signed-off-by: nncluzu <ngamenichaka@yahoo.fr>
@kmer2016
front: wire cell edit callbacks to TimesStopsOutput
2363718 
Signed-off-by: nncluzu <ngamenichaka@yahoo.fr>
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 23, 2026
@kmer2016 kmer2016 mentioned this pull request Jan 23, 2026
Open
@achrafmohye
Copy link
Contributor

achrafmohye commented Jan 23, 2026

Seems like the simulation doesn't retrigger when the arrival time is changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achrafmohye achrafmohye Awaiting requested review from achrafmohye

@SharglutDev SharglutDev Awaiting requested review from SharglutDev

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

area:front Work on Standard OSRD Interface modules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement the function for table editable cell

3 participants

@kmer2016 @achrafmohye