Skip to content

fix(security): add input validation to makeDockerExec #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
la14-1 merged 2 commits into from
Mar 25, 2026
Merged

fix(security): add input validation to makeDockerExec #2987

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f63fbbb
fix(security): add input validation to makeDockerExec
louisgv Mar 25, 2026
1b5f5cd
Merge branch 'main' into fix/issue-2985
louisgv Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/cli/src/shared/orchestrate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ export const DOCKER_REGISTRY = "ghcr.io/openrouterteam";

/** Wrap a command to run inside the Docker container instead of the host. */
export function makeDockerExec(cmd: string): string {
if (!cmd || cmd.length === 0) {
throw new Error("makeDockerExec: command must be non-empty");
}
return `docker exec ${DOCKER_CONTAINER_NAME} bash -c ${shellQuote(cmd)}`;
}

Expand Down
Loading