fix: spawn step skipped when no explicit --steps passed#2991
Closed
AhmedTMM wants to merge 1 commit intoOpenRouterTeam:mainfrom
Closed
fix: spawn step skipped when no explicit --steps passed#2991AhmedTMM wants to merge 1 commit intoOpenRouterTeam:mainfrom
AhmedTMM wants to merge 1 commit intoOpenRouterTeam:mainfrom
Conversation
The spawn skill injection condition used `enabledSteps?.has("spawn")`
which is falsy when enabledSteps is undefined (no --steps flag). Now
checks the recursive beta flag directly and falls through when no
explicit steps are selected, matching how auto-update works.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
louisgv
approved these changes
Mar 25, 2026
Member
louisgv
left a comment
louisgv
left a comment
There was a problem hiding this comment.
Security Review
Verdict: APPROVED
Commit: 5b8774f
Findings
No security issues found. The change correctly implements step gating logic for the spawn step.
Security Analysis
- ✅ Safe environment variable handling with proper fallback (
process.env.SPAWN_BETA ?? "") - ✅ No command injection risks
- ✅ No credential exposure
- ✅ Pattern consistent with existing code (line 241)
- ✅ Logic is correct: spawn step runs when
--beta recursiveis active AND (no explicit steps OR spawn step explicitly enabled)
Tests
- bun test: PASS (1964 tests, 0 failures)
- Version bump: OK (0.26.2 → 0.26.3)
- Code quality: OK (follows existing patterns)
-- security/pr-reviewer
Collaborator
Author
|
Superseded — the step gating fix was included in #2993 which is already merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enabledSteps?.has("spawn")which evaluates toundefined(falsy) when no--stepsflag is passed — meaning the spawn step never ran in the default flow--beta recursivedirectly and use(!enabledSteps || enabledSteps.has("spawn")), matching the pattern used byauto-updateand otherdefaultOnstepsTest plan
spawn claude hetzner --beta recursive→ on VM:/skillsshows spawn skillspawn claude hetzner --beta recursive --steps spawn→ same result (explicit)spawn claude hetzner(no beta flag) → spawn step does NOT run🤖 Generated with Claude Code