Merge pull request #334 from OpenSEMBA/tests-time-domain-default-behavior Adds test to check time domain default behavior.

.gitignore

@@ -73,4 +73,5 @@ fort.17
 src_main_pub/version.F90
 git_info.txt
 
-.venv/
+.venv/build2/
+build2/

.vscode/extensions.json

@@ -0,0 +1,34 @@
+{
+	// See https://go.microsoft.com/fwlink/?LinkId=827846 to learn about workspace recommendations.
+	// Extension identifier format: ${publisher}.${name}. Example: vscode.csharp
+
+	// List of extensions which should be recommended for users of this workspace.
+	"recommendations": [
+		// Fortran language support and linting
+		"fortran-lang.linter-gfortran",
+
+		// CMake support
+		"ms-vscode.cmake-tools",
+		"twxs.cmake",
+
+		// C++ tools (used alongside Fortran in this project)
+		"ms-vscode.cpptools",
+		"ms-vscode.cpp-devtools",
+
+		// Testing
+		"matepek.vscode-catch2-test-adapter",
+		"fredericbonnet.cmake-test-adapter",
+
+		// Git
+		"mhutchie.git-graph",
+		"github.vscode-pull-request-github",
+
+		// GitHub Copilot
+		"github.copilot",
+		"github.copilot-chat"
+	],
+	// List of extensions recommended by VS Code that should not be recommended for users of this workspace.
+	"unwantedRecommendations": [
+
+	]
+}

doc/fdtdjson.md

@@ -821,6 +821,16 @@ A `generator` source must be located on a single `node` whose `coordinateId` is
 }
 ```
 
+Using classic wires, generators can be located on any node of the lines. Using MTLN wires there are some restrictions:
+
+| Syntax      | `unshieldedMultiwire` | `shieldedMultiwire` |
+| :---        |    :---   |          :--- |
+| Voltage     | Only wire extremes       | Any point      |
+| Current     | Any point        | Only wire extremes      |
+
+In case a generator is on a wire extreme, the current direction will be from the generator in the direction of the other wire extreme. If the generator is on an interior wire point, the current direction will be oriented as the wire.
+
+
 In case the generator is located at the junction (connection point) of two of more lines, the  `node` shared by the lines will share the same  `coordinateId`. If more than two lines are connected together, it is necessary to know to which of the lines the generator is connected to. The entry `[attachedToLineId]` is an integer which refers to the `elementId` of the `polyline` the source is connected to. 
 
 **Example:**

scripts/install-packages.sh

@@ -0,0 +1,66 @@
+#!/bin/bash
+# Install script for ugrfdtd development environment
+# Generated for Ubuntu 24.04 LTS (Noble Numbat) x86_64
+
+set -e
+
+echo "=== Updating package lists ==="
+sudo apt update
+
+echo "=== Installing build tools ==="
+sudo apt install -y \
+    build-essential \
+    cmake \
+    ninja-build \
+    git \
+    gdb \
+    pkg-config
+
+echo "=== Installing Fortran compiler ==="
+sudo apt install -y \
+    gfortran
+
+echo "=== Installing MPI ==="
+sudo apt install -y \
+    libopenmpi-dev \
+    openmpi-bin \
+    openmpi-common
+
+echo "=== Installing HDF5 ==="
+sudo apt install -y \
+    libhdf5-dev \
+    hdf5-helpers
+
+echo "=== Installing Python development tools ==="
+sudo apt install -y \
+    python3-dev \
+    python3-pip
+
+
+echo "=== Installing Python packages ==="
+pip3 install --break-system-packages fortls
+
+COMPILER_VERSION="2025.1"
+
+echo "=== Adding Intel oneAPI apt repository ==="
+KEY="GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB"
+curl -fsSL "https://apt.repos.intel.com/intel-gpg-keys/$KEY" \
+    | sudo apt-key add -
+echo "deb https://apt.repos.intel.com/oneapi all main" \
+    | sudo tee /etc/apt/sources.list.d/oneAPI.list
+sudo apt-get update -q
+
+echo "=== Installing Intel Fortran + C/C++ compilers (${COMPILER_VERSION}) ==="
+sudo apt-get install -y \
+    intel-oneapi-compiler-fortran-${COMPILER_VERSION} \
+    intel-oneapi-compiler-dpcpp-cpp-${COMPILER_VERSION}
+
+echo "=== Installing Intel MPI ==="
+sudo apt-get install -y \
+    intel-oneapi-mpi \
+    intel-oneapi-mpi-devel
+
+echo ""
+echo "=== All packages installed successfully ==="
+echo "Source the Intel environment before building:"
+echo "  source /opt/intel/oneapi/setvars.sh"

src_conformal/conformal.F90

@@ -87,7 +87,7 @@ function addEdgeMedia(edges, edge_ratios) result(res)
          allocate(res(i)%edges(size(filtered_edges)))
          res(i)%edges = filtered_edges
          res(i)%ratio = edge_ratios(i)
-         res(i)%size = size(filtered_edges)
+         res(i)%n_elements = size(filtered_edges)
       end do
    end function
 
@@ -102,7 +102,7 @@ function addFaceMedia(faces, face_ratios) result(res)
          allocate(res(i)%faces(size(filtered_faces)))
          res(i)%faces = filtered_faces
          res(i)%ratio = face_ratios(i)
-         res(i)%size = size(filtered_faces)
+         res(i)%n_elements = size(filtered_faces)
       end do
 
    end function

src_json_parser/parser_tools.F90

@@ -194,20 +194,20 @@ function getPixelFromElementId(mesh, id) result(res)
 
    function vectorToDiagonalMatrix(vector) result(res)
       real(kind=RKIND), dimension(:), intent(in) :: vector
-      real, dimension(:, :), allocatable :: res
+      real(kind=rkind), dimension(:, :), allocatable :: res
       integer :: i, n
       n = size(vector, 1)
-      allocate(res(n,n), source = 0.0)
+      allocate(res(n,n), source = 0.0_rkind)
       do i = 1, n
-         res(i,i) = real(vector(i))
+         res(i,i) = vector(i)
       end do
    end function
 
    function scalarToMatrix(scalar) result(res)
       real(kind=RKIND), intent(in) :: scalar
-      real, dimension(:, :), allocatable :: res
-      allocate(res(1,1), source = 0.0)
-      res(1,1) = real(scalar)
+      real(kind=rkind), dimension(:, :), allocatable :: res
+      allocate(res(1,1), source = 0.0_rkind)
+      res(1,1) = scalar
    end function
 
    subroutine splitLineIntoWords(line, words)

src_json_parser/smbjson.F90

@@ -1033,9 +1033,11 @@ function readPlanewave(pw) result (res)
          res%beta = this%getRealAt(pw, J_SRC_PW_POLARIZATION//'.'//J_SRC_PW_PHI)
 
          block
+            type(cell_interval_t), dimension(:), allocatable :: cellIntervals
             type(coords_t), dimension(:), allocatable :: nfdeCoords
-            nfdeCoords = &
-               cellIntervalsToCoords(this%getSingleVolumeInElementsIds(pw))
+            cellIntervals = this%getSingleVolumeInElementsIds(pw)
+            if (size(cellIntervals) == 0) return
+            nfdeCoords = cellIntervalsToCoords(cellIntervals)
             res%coor1 = [nfdeCoords(1)%Xi, nfdeCoords(1)%Yi, nfdeCoords(1)%Zi]
             res%coor2 = [nfdeCoords(1)%Xe, nfdeCoords(1)%Ye, nfdeCoords(1)%Ze]
          end block
@@ -2072,19 +2074,30 @@ function readGeneratorOnThinWire(linels, plineElemIds) result(res)
 
                select case(this%getStrAt(genSrcs(i)%p, J_FIELD))
                 case (J_FIELD_VOLTAGE)
-                  res(position)%srctype = "VOLT"
-                  res(position)%srcfile = this%getStrAt(genSrcs(i)%p, J_SRC_MAGNITUDE_FILE)
-                  res(position)%multiplier = 1.0_RKIND
+                  res(position)%srctype = F_SOURCE_VOLTAGE
                 case (J_FIELD_CURRENT)
-                  res(position)%srctype = "CURR"
-                  res(position)%srcfile = this%getStrAt(genSrcs(i)%p, J_SRC_MAGNITUDE_FILE)
-                  res(position)%multiplier = 1.0_RKIND
-                case default
+                  res(position)%srctype = F_SOURCE_CURRENT
+               case default
                   call WarnErrReport('Field block of source of type generator must be current or voltage', .true.)
                end select
+               res(position)%srcfile = this%getStrAt(genSrcs(i)%p, J_SRC_MAGNITUDE_FILE)
+               res(position)%multiplier = 1.0_RKIND*orientFieldFromGenerator(linels, position)
 
             end do
          end block
+      end function
+
+      function orientFieldFromGenerator(linels, position) result(res)
+         type(linel_t), dimension(:), intent(in) :: linels
+         integer :: position
+         integer :: res
+         if (position == 1) then 
+            res = sign(1,linels(position)%orientation)
+         else if  (position == size(linels)) then 
+            res = -sign(1,linels(position)%orientation)
+         else
+            res = sign(1,linels(position)%orientation)
+         end if
 
       end function
 
@@ -3771,10 +3784,10 @@ subroutine assignPULProperties(res, mat, n)
          type(shielded_multiwire_t), intent(inout) :: res
          type(json_value_ptr_t) :: mat
          integer, intent(in) :: n
-         real, dimension(:,:), allocatable :: null_matrix
+         real(kind=rkind), dimension(:,:), allocatable :: null_matrix
          logical :: found
 
-         allocate(null_matrix(n,n), source = 0.0)
+         allocate(null_matrix(n,n), source = 0.0_rkind)
          if (this%existsAt(mat%p, J_MAT_MULTIWIRE_INDUCTANCE)) then
             res%inductance_per_meter = this%getMatrixAt(mat%p, J_MAT_MULTIWIRE_INDUCTANCE,found)
          else
@@ -3808,14 +3821,14 @@ subroutine assignInCellProperties(res, mat, n)
          type(json_value), pointer :: multipolarExpansionPtr
          integer, intent(in) :: n
          integer :: m
-         real, dimension(:,:), allocatable :: null_matrix
+         real(kind=rkind), dimension(:,:), allocatable :: null_matrix
          logical :: found
          logical :: areFixedInCell
          logical :: areMultipolarInCell
          logical :: hasRadius
          real(kind=RKIND), dimension(:), allocatable :: r, c
 
-         allocate(null_matrix(n,n), source = 0.0)
+         allocate(null_matrix(n,n), source = 0.0_rkind)
 
          areFixedInCell = &
             this%existsAt(mat%p, J_MAT_MULTIWIRE_INDUCTANCE) .and. &
@@ -3978,7 +3991,7 @@ function buildSegments(j_cable, despl) result(res)
                case(DIR_Y)
                   res(i)%dualBox = getdualBoxZX(res(i), despl)
                   res(i)%d1 = despl%desZ(res(i)%z-1)
-                  res(i)%d1 = despl%desX(res(i)%x-1)
+                  res(i)%d2 = despl%desX(res(i)%x-1)
                case(DIR_Z)
                   res(i)%dualBox = getdualBoxXY(res(i), despl)
                   res(i)%d1 = despl%desX(res(i)%x-1)
@@ -4043,7 +4056,7 @@ function getdualBoxZX(segment, despl) result (res)
       function buildStepSize(segments, despl) result(res)
          type(segment_t), dimension(:), allocatable :: segments
          type(Desplazamiento_t), intent(in) :: despl
-         real, allocatable, dimension(:) :: res
+         real(kind=rkind), allocatable, dimension(:) :: res
          integer :: i, or
          allocate(res(size(segments)))
          do i = 1, size(segments)
@@ -4388,19 +4401,32 @@ function getSingleVolumeInElementsIds(this, pw) result (res)
       elemIds = this%getIntsAt(pw, J_ELEMENTIDS, found=found)
       if (.not. found) then
          call WarnErrReport("Error reading single volume elementIds label not found.", .true.)
+         allocate(res(0))
+         return
+      end if
+      if (size(elemIds) == 0) then
+         call WarnErrReport("Entity elementIds must not be empty.", .true.)
+         allocate(res(0))
+         return
       end if
       if (size(elemIds) /= 1) then
          call WarnErrReport("Entity must contain a single elementId.", .true.)
+         allocate(res(0))
+         return
       end if
       cellRegion = this%mesh%getCellRegion(elemIds(1), found)
       if (.not. found) then
          write(errorMsg, *) "Entity elementId ", elemIds(1), " not found."
          call WarnErrReport(errorMsg, .true.)
+         allocate(res(0))
+         return
       end if
       res = cellRegion%getIntervalsOfType(CELL_TYPE_VOXEL)
       if (size(res) /= 1) then
          write(errorMsg, *) "Entity must contain a single cell region defining a volume."
          call WarnErrReport(errorMsg, .true.)
+         allocate(res(0))
+         return
       end if
    end function