Skip to content

Conversation

@emjay0921
Copy link
Contributor

Why is this change needed?

  1. To not install spp_base_demo when spp_farmer_registry_demo is installed.
  2. To fix the problem with the Highest Educational Level.

How was the change implemented?

  1. Removed spp_base_demo on spp_farmer_registry_demo depends, and add gender data xml.
  2. Added the same selection values from res_partner to spp_farmer.

New unit tests

None

Unit tests executed by the author

None

How to test manually

  • Install spp_farmer_registry_demo on new instance or make sure spp_base_demo is not installed by uninstalling spp_farmer_registry_demo first.

Test 1

  • Check if spp_base_demo is installed (should not be installed automatically).

Test 2

  • Go to Configuration > Gender Types.
  • Check if Male and Female are existing in the Gender Types.

Test 3

  • Go to Group > Select or Open one.
  • Check if Farmer Highest Educational Level selections is the same with Individual's Highest Educational Level.

Related links

https://github.com/orgs/OpenSPP/projects/5/views/4?pane=issue&itemId=81324763

@emjay0921 emjay0921 linked an issue Oct 3, 2024 that may be closed by this pull request
@github-actions github-actions bot requested a review from jeremi October 3, 2024 06:47
Copy link
Member

@reichie020212 reichie020212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emjay0921 as discussed earlier with @gonzalesedwin1123 , create a new module for the gender and locale provider. Thanks.

@emjay0921
Copy link
Contributor Author

Sorry for the message of the latest commit, it was supposed to be "remove user data for program in spp_base_demo".

@reichie020212 reichie020212 self-requested a review October 4, 2024 02:49
@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.23%. Comparing base (c2d1b67) to head (098063e).
Report is 7 commits behind head on 17.0.

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #617      +/-   ##
==========================================
- Coverage   73.50%   73.23%   -0.28%     
==========================================
  Files         560      544      -16     
  Lines       14084    13623     -461     
  Branches     1799     1750      -49     
==========================================
- Hits        10353     9977     -376     
+ Misses       3414     3348      -66     
+ Partials      317      298      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anjclarise
Copy link

TEST 1:
Upon checking spp_base_demo is installed (should not be installed automatically). spp_base_demo was only installed after adding spp_farmer_registry_demo. Regarding this, @reichie020212 @Markpenalosa should this be the expected? In the HOW TO TEST MANUALLY is was specified that:

Install spp_farmer_registry_demo on new instance or make sure spp_base_demo is not installed by uninstalling spp_farmer_registry_demo first.

  • spp_farmer_registry_demo not yet installed in a new instance
    image

  • spp_farmer_registry_demo already installed in the instance
    image

image

TEST 2:

  • Under Configuration >> Gender Types (Male and Female are NOT on the list) .
    image

TEST 3:

  • Individual highest education status:
image
  • Farmer highest education status:
image

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@emjay0921 emjay0921 merged commit d35e55b into 17.0 Nov 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
@jeremi jeremi deleted the 606-fix-farmer-registry-demo branch September 15, 2025 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Farmer registry demo module

5 participants