Skip to content

Conversation

@gonzalesedwin1123
Copy link
Member

@gonzalesedwin1123 gonzalesedwin1123 commented Oct 24, 2024

Why is this change needed?

Conflicting modules, such as spp_base (SP-MIS), spp_farmer_registry_base (Farmer Registry) and other associated modules, can be activated by the admin user via the Odoo "Apps" UI. This could lead to errors due to conflicts between the modules. To prevent these issues, "excludes" in the manifest.py of the conflicting modules should be added.

How was the change implemented?

Modify the manifest.py files of the conflicting modules to add the module exclusions.

New unit tests

None

Unit tests executed by the author

None

How to test manually

When installing the following modules, an error will be displayed when its conflicting module is already installed:

SPMIS:

  • spp_base conflicts with spp_farmer_registry_base
  • spp_change_request_add_children_demo conflicts with spp_farmer_registry_base

Farmer Registry:

  • spp_farmer_registry_base conflicts with spp_base
  • spp_change_request_add_farmer conflicts with spp_base
  • spp_farmer_registry_default_ui conflicts with spp_base
  • spp_farmer_registry_demo conflicts with spp_base

Related links

Add a way to prevent conflicting modules to be activated

@gonzalesedwin1123 gonzalesedwin1123 marked this pull request as ready for review October 24, 2024 12:05
@gonzalesedwin1123 gonzalesedwin1123 removed the request for review from jeremi October 24, 2024 12:05
@gonzalesedwin1123 gonzalesedwin1123 linked an issue Oct 24, 2024 that may be closed by this pull request
@kneckinator kneckinator marked this pull request as draft October 28, 2024 02:25
@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.01%. Comparing base (ab91df9) to head (f6a0ad8).
Report is 232 commits behind head on 17.0.

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #644      +/-   ##
==========================================
+ Coverage   73.22%   76.01%   +2.79%     
==========================================
  Files         545      582      +37     
  Lines       13631    15179    +1548     
  Branches     1751     1898     +147     
==========================================
+ Hits         9981    11539    +1558     
+ Misses       3352     3262      -90     
- Partials      298      378      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonzalesedwin1123 gonzalesedwin1123 marked this pull request as ready for review October 29, 2024 07:59
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
27 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@emjay0921 emjay0921 merged commit a09208c into 17.0 Nov 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
@gonzalesedwin1123 gonzalesedwin1123 deleted the 634-openspp-modules branch April 25, 2025 01:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a way to prevent conflicting modules to be activated

5 participants