Skip to content

Conversation

@emjay0921
Copy link
Contributor

Why is this change needed?

To fix the error when using spp_starter for demo.

How was the change implemented?

Added spp_base_demo and renamed spp_demo to spp_mis_demo.

New unit tests

None

Unit tests executed by the author

None

How to test manually

  • On newly set instance or runboat install spp_starter.
  • Proceed with the setup. (Try with SP-MIS and Farmer Registry, also make sure to test this as demo)
  • If proceeded with no error then PR is done.

Related links

#660

@emjay0921 emjay0921 linked an issue Nov 12, 2024 that may be closed by this pull request
@emjay0921 emjay0921 removed the request for review from jeremi November 12, 2024 06:07
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.30%. Comparing base (ba02c29) to head (658ae31).
Report is 222 commits behind head on 17.0.

Files with missing lines Patch % Lines
spp_starter/wizards/spp_starter.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #661      +/-   ##
==========================================
- Coverage   76.28%   72.30%   -3.98%     
==========================================
  Files         571      649      +78     
  Lines       14812    17177    +2365     
  Branches     1861     2236     +375     
==========================================
+ Hits        11299    12420    +1121     
- Misses       3140     4363    +1223     
- Partials      373      394      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@emjay0921 emjay0921 merged commit 06f58da into 17.0 Nov 19, 2024
1 of 3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
@jeremi jeremi deleted the 660-fix-spp-starter branch September 15, 2025 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix SPP Starter for demo modules

4 participants