Skip to content

Conversation

@shashikala1998
Copy link
Contributor

@shashikala1998 shashikala1998 commented Nov 15, 2024

Why is this change needed?

The custom filter module is designed to limit the fields that can be selected in the domain filter widget. This PR provides the coverage of additional fields that can be filtered in the following modules:

  1. SPMIS
  • tags_ids
  1. Farmer Registry
  • farmer_national_id
  • farmer_postal_address
  • marital_status
  • highest_education_level
  1. SPMIS demo
  • z_ind_grp_is_single_head_hh
  • z_ind_grp_is_hh_with_medical_condition
  • z_ind_grp_is_hh_with_children
  • z_cst_indv_medical_condition
  1. Farmer Registry demo
  • marital_status
  • highest_education_level

How was the change implemented?

This module is built by extending the spp_custom_filter_ui module and introduces filter options for the fields in the spp_base, spp_farmer_registry_base, and spp_mis_demo modules.

New unit tests

N/A

Unit tests executed by the author

N/A

How to test manually

  1. Install the spp_custom_filter_farmer_registry module.
  2. Navigate to the "Individuals" section in the registry.
  3. Access the filter options available.
  4. Test the newly added filter options.

Related links

#650

@gonzalesedwin1123
Copy link
Member

@shashikala1998 please fix also the pre-commit errors

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.62%. Comparing base (a09208c) to head (9864708).
Report is 47 commits behind head on 17.0.

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #663      +/-   ##
==========================================
- Coverage   72.75%   72.62%   -0.13%     
==========================================
  Files         618      667      +49     
  Lines       16453    17214     +761     
  Branches     2116     2186      +70     
==========================================
+ Hits        11970    12502     +532     
- Misses       4096     4318     +222     
- Partials      387      394       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonzalesedwin1123 gonzalesedwin1123 merged commit 5a517a6 into 17.0 Jan 9, 2025
7 of 9 checks passed
@gonzalesedwin1123 gonzalesedwin1123 deleted the 650-openspp-modules branch January 9, 2025 06:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend the spp_custom_filter to support the SPMIS, Farmer Registry, and demo modules

5 participants