Skip to content

Conversation

@emjay0921
Copy link
Contributor

@emjay0921 emjay0921 commented Feb 10, 2025

Why is this change needed?

To fix the problem on Cash Entitlements where if Max amount was set the entitlements follows the Max amount value.

How was the change implemented?

Fix the _check_subsidy function.

New unit tests

TestEntitlementManager

Unit tests executed by the author

TestEntitlementManager

How to test manually

  • Install or Upgrade spp_entitlement_cash.
  • Create a Program with Cash as the Entitlement Manager and set the Max amount.
  • Create Cycle and Prepare Entitlements.
  • Check if the initial amount is correct.

Related links

#728

@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.95%. Comparing base (9d21f2d) to head (96f1d39).
Report is 10 commits behind head on 17.0.

Files with missing lines Patch % Lines
spp_entitlement_cash/models/entitlement_manager.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #742      +/-   ##
==========================================
+ Coverage   75.80%   75.95%   +0.14%     
==========================================
  Files         706      706              
  Lines       17906    17927      +21     
  Branches     2225     2223       -2     
==========================================
+ Hits        13574    13616      +42     
+ Misses       3869     3851      -18     
+ Partials      463      460       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emjay0921 emjay0921 force-pushed the 728-entitlement-manager-cash branch from 24734e5 to 41f2077 Compare February 12, 2025 01:39
@sonarqubecloud
Copy link

@emjay0921 emjay0921 merged commit fb6cbb1 into 17.0 Feb 18, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
@gonzalesedwin1123 gonzalesedwin1123 deleted the 728-entitlement-manager-cash branch February 18, 2025 06:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Defective maximum amount field for entitlement manager Cash

4 participants