Skip to content

Conversation

@gonzalesedwin1123
Copy link
Member

@gonzalesedwin1123 gonzalesedwin1123 commented Feb 12, 2025

Why is this change needed?

There is a need for the spp_area module to be used in non OpenG2P, SP-MIS, and Farmer Registry implementations. This will introduce a new spp_area_base module that will contain the core of the module and convert the current spp_area module for OpenG2P, SP-MIS, and Farmer Registry specific implementations.

How was the change implemented?

  • Develop a new module spp_area_base that defines the area and area import models.
  • Modify the current spp_area to depend on spp_area_base and maintain support to the OpenG2P, SP-MIS, and Farmer Registry implementations.

New unit tests

  • BaseAreaTest: test_01_check_childs
  • BaseAreaImportTest: test_01_cancel_area_import, test_02_reset_to_uploaded_area, test_03_import_area_data, test_06_reload_page, test_07_async_mark_import_done
  • BaseAreaImportRawTest: test_01_validate_import_raw_data_no_error, test_02_validate_import_raw_data_with_error, test_03_save_import_to_area

Unit tests executed by the author

  • BaseAreaTest: test_01_check_childs
  • BaseAreaImportTest: test_01_cancel_area_import, test_02_reset_to_uploaded_area, test_03_import_area_data, test_06_reload_page, test_07_async_mark_import_done
  • BaseAreaImportRawTest: test_01_validate_import_raw_data_no_error, test_02_validate_import_raw_data_with_error, test_03_save_import_to_area

How to test manually

  • Install the spp_area_base.
  • The Fertilizer Distributor Registry module should have the area model integrated.

Related links

Changes to be made on Area Module for Sri Lanka Fertilizer Distributor Registry

@gonzalesedwin1123 gonzalesedwin1123 linked an issue Feb 12, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 93.58974% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.96%. Comparing base (9d21f2d) to head (ea209f1).
Report is 6 commits behind head on 17.0.

Files with missing lines Patch % Lines
spp_area_base/models/area_import.py 71.42% 8 Missing ⚠️
spp_area_base/models/area.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #747      +/-   ##
==========================================
+ Coverage   75.80%   75.96%   +0.15%     
==========================================
  Files         706      713       +7     
  Lines       17906    18020     +114     
  Branches     2225     2228       +3     
==========================================
+ Hits        13574    13688     +114     
  Misses       3869     3869              
  Partials      463      463              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

@gonzalesedwin1123 gonzalesedwin1123 merged commit acc80c6 into 17.0 Feb 18, 2025
8 checks passed
@gonzalesedwin1123 gonzalesedwin1123 deleted the 746-changes-to-be-made-on-area-module-for-sri-lanka-fertilizer-distributor-registry branch February 18, 2025 07:06
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes to be made on Area Module

4 participants