Skip to content

Conversation

@emjay0921
Copy link
Contributor

Why is this change needed?

To modify the Add Farmer CR to be able to add Farmer to a Farm.

How was the change implemented?

Modified and Improved the CR for Add Farmer

New unit tests

TestChangeRequestAddFarmer

Unit tests executed by the author

TestChangeRequestAddFarmer

How to test manually

  • Install or Upgrade spp_change_request_add_farmer.
  • Create CR with Type Add Farmer.
  • Proceed to Fill the required Fields.
  • Validate and Apply.

Related links

#682

@emjay0921 emjay0921 linked an issue Feb 12, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.84%. Comparing base (9d21f2d) to head (532e894).
Report is 6 commits behind head on 17.0.

Files with missing lines Patch % Lines
...est_add_farmer/models/change_request_add_farmer.py 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #748      +/-   ##
==========================================
+ Coverage   75.80%   75.84%   +0.04%     
==========================================
  Files         706      705       -1     
  Lines       17906    17771     -135     
  Branches     2225     2198      -27     
==========================================
- Hits        13574    13479      -95     
+ Misses       3869     3840      -29     
+ Partials      463      452      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

@gonzalesedwin1123 gonzalesedwin1123 merged commit 9f2fbf2 into 17.0 Feb 18, 2025
7 checks passed
@gonzalesedwin1123 gonzalesedwin1123 deleted the 682-create-cr-type-add-farmer branch February 18, 2025 09:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create CR type add-farmer

4 participants