Skip to content

Conversation

@emjay0921
Copy link
Contributor

Why is this change needed?

To have a CR Type of Adding a Group to A Group.

How was the change implemented?

Created new module for CR Type: Add Group to Group, extending spp_group_hierarchy.

New unit tests

TestChangeRequestAddGroupToGroup

Unit tests executed by the author

TestChangeRequestAddGroupToGroup

How to test manually

  • Install spp_change_request_add_group_to_group
  • Create a CR with type: Add Group to Group
  • Fill required Fields.
  • Validate and Approve.

Related links

#744

@emjay0921 emjay0921 linked an issue Feb 18, 2025 that may be closed by this pull request
1 task
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.96%. Comparing base (9d21f2d) to head (4f48373).
Report is 160 commits behind head on 17.0.

Files with missing lines Patch % Lines
..._group/models/change_request_add_group_to_group.py 90.90% 3 Missing and 3 partials ⚠️
..._request_add_group_to_group_validation_sequence.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #751      +/-   ##
==========================================
+ Coverage   75.80%   75.96%   +0.15%     
==========================================
  Files         706      714       +8     
  Lines       17906    18053     +147     
  Branches     2225     2234       +9     
==========================================
+ Hits        13574    13714     +140     
- Misses       3869     3872       +3     
- Partials      463      467       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonzalesedwin1123 gonzalesedwin1123 merged commit 7449e59 into 17.0 Feb 18, 2025
9 checks passed
@gonzalesedwin1123 gonzalesedwin1123 deleted the 744-create-cr-type-add-farm branch February 18, 2025 09:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create CR type add-farm

4 participants