Skip to content

Conversation

@reichie020212
Copy link
Member

Why is this change needed?

How was the change implemented?

New unit tests

Unit tests executed by the author

How to test manually

Related links

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.04%. Comparing base (5a74c7d) to head (09ed334).

Files with missing lines Patch % Lines
...pp_programs/models/managers/eligibility_manager.py 25.00% 3 Missing ⚠️
spp_eligibility_sql/models/eligibility_manager.py 0.00% 1 Missing ⚠️
spp_eligibility_tags/models/eligibility_manager.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #761      +/-   ##
==========================================
- Coverage   76.07%   76.04%   -0.03%     
==========================================
  Files         756      756              
  Lines       19243    19243              
  Branches     2340     2341       +1     
==========================================
- Hits        14639    14634       -5     
- Misses       4097     4103       +6     
+ Partials      507      506       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reichie020212 reichie020212 merged commit 423d43c into 17.0 Feb 24, 2025
5 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2025
@jeremi jeremi deleted the 5-sl-compliance-criteria-2 branch September 15, 2025 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants