Skip to content

Conversation

@reichie020212
Copy link
Member

@reichie020212 reichie020212 commented Mar 12, 2025

Why is this change needed?

Currently spp_hide_menus is only for SPMIS and Farmer Registry.
A base module for spp_hide_menus is needed.

How was the change implemented?

Created a new module named spp_hide_menus_base

New unit tests

None

Unit tests executed by the author

None

How to test manually

  • Install spp_hide_menus_base and spp_hide_menus
  • Go to Settings -> Users & Companies -> Hidden Menus
  • Check if there are created records.

@sonarqubecloud
Copy link

emjay0921

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.02%. Comparing base (aa6587c) to head (4dd818e).

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #781      +/-   ##
==========================================
- Coverage   75.03%   75.02%   -0.02%     
==========================================
  Files         727      727              
  Lines       19228    19228              
  Branches     2400     2400              
==========================================
- Hits        14427    14425       -2     
  Misses       4293     4293              
- Partials      508      510       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@reichie020212
Copy link
Member Author

Please add description @reichie020212 .

Done

@reichie020212 reichie020212 merged commit 60c70be into 17.0 Mar 12, 2025
8 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2025
@jeremi jeremi deleted the base-spp-hide-menus-module branch September 15, 2025 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants