Skip to content

Conversation

@reichie020212
Copy link
Member

Why is this change needed?

How was the change implemented?

New unit tests

Unit tests executed by the author

How to test manually

Related links

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.07%. Comparing base (121ca77) to head (48376b8).
Report is 11 commits behind head on 17.0.

Files with missing lines Patch % Lines
spp_openid_vci/models/ir_actions_report.py 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #784      +/-   ##
==========================================
+ Coverage   75.02%   75.07%   +0.05%     
==========================================
  Files         727      730       +3     
  Lines       19228    19285      +57     
  Branches     2400     2400              
==========================================
+ Hits        14426    14479      +53     
- Misses       4293     4298       +5     
+ Partials      509      508       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@gonzalesedwin1123 gonzalesedwin1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reichie020212 I suggest point the logo to a path in our base module to make this universal.

@reichie020212
Copy link
Member Author

@reichie020212 I suggest point the logo to a path in our base module to make this universal.

@gonzalesedwin1123 the spp_openid_vci module is the base module of the verifiable credential modules.

@reichie020212 reichie020212 merged commit 700dbb3 into 17.0 Mar 24, 2025
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2025
@jeremi jeremi deleted the spp-openid-vci-imp branch September 15, 2025 11:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants