Skip to content

Conversation

@shashikala1998
Copy link
Contributor

Why is this change needed?

When approving a change request,An event data to update

How was the change implemented?

  1. Inherit spp_event_data and spp_change_request modules and add event data page on notebook of change request. Once approve a change request data will be save on event data section on change request

New unit tests

N/A

Unit tests executed by the author

N/A

How to test manually

  1. In a fresh database install spp_event_data and spp_change_request modules or install spp_change_request_event_data then other dependency modules will install automatically.
  2. Define user roles to users
  3. Create a change request (ex: add farmer CR, update farmer CR)
  4. once approve the CR, system will automatically create event data on relevant change request
Screenshot 2025-03-25 at 22 24 31

Related links

#714

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

❌ Patch coverage is 43.75000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.02%. Comparing base (aa7a32f) to head (5274200).
⚠️ Report is 60 commits behind head on 17.0.

Files with missing lines Patch % Lines
...change_request_event_data/models/change_request.py 28.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #786      +/-   ##
==========================================
- Coverage   75.07%   75.02%   -0.06%     
==========================================
  Files         730      734       +4     
  Lines       19285    19317      +32     
  Branches     2400     2404       +4     
==========================================
+ Hits        14479    14492      +13     
- Misses       4298     4316      +18     
- Partials      508      509       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@gonzalesedwin1123 gonzalesedwin1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shashikala1998 Let's wait for the final approval of fields that will be stored in the events data model. Meanwhile, I suggest you set this PR to draft.

@reichie020212 reichie020212 marked this pull request as draft April 7, 2025 09:42
@reichie020212
Copy link
Member

Setting this PR to draft since the requirements for this PR/ticket is not yet complete.

@gonzalesedwin1123
Copy link
Member

@shashikala1998 I will close this for now but will be re-opened when we have this covered in our future plans.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save approved change requests as event data

4 participants