Skip to content

Conversation

@kneckinator
Copy link
Contributor

Why is this change needed?

  • To reduce the wait for URL timeout during module initialization
  • To prevent something unexpected from responding to that DNS

How was the change implemented?

The URL has been replaced with placeholder data, which should trigger an error since it is not a valid URI

New unit tests

N/A

Unit tests executed by the author

Entire test suite

How to test manually

  1. Install the OpenSPP DCI Import API
  2. Validate that the data source CRVS field is set to --Not Set--

Related links

N/A

@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.67%. Comparing base (1a155de) to head (0c6deab).
Report is 4 commits behind head on 17.0.

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #792      +/-   ##
==========================================
- Coverage   75.68%   75.67%   -0.01%     
==========================================
  Files         764      764              
  Lines       20218    20218              
  Branches     2501     2501              
==========================================
- Hits        15301    15300       -1     
  Misses       4382     4382              
- Partials      535      536       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kneckinator kneckinator force-pushed the ken/remove_opencrvs_demo_data branch from 6b93a28 to 0c6deab Compare April 28, 2025 01:30
@sonarqubecloud
Copy link

@kneckinator kneckinator merged commit bb28b61 into 17.0 Apr 28, 2025
7 checks passed
@kneckinator kneckinator deleted the ken/remove_opencrvs_demo_data branch April 28, 2025 07:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants