fix(STEF-2802): anchor mlflow gitignore patterns to repo root#814
Merged
egordm merged 1 commit intorelease/v4.0.0from Feb 20, 2026
Merged
fix(STEF-2802): anchor mlflow gitignore patterns to repo root#814egordm merged 1 commit intorelease/v4.0.0from
egordm merged 1 commit intorelease/v4.0.0from
Conversation
The bare 'mlflow' pattern matched anywhere in the tree, which caused hatchling to exclude packages/openstef-models/src/openstef_models/integrations/mlflow/ from the built wheel. Root-anchoring with '/mlflow' limits the match to only the top-level mlflow directory (local MLflow data). Broken since v4.0.0.a17 (commit 1bcf71d). Signed-off-by: Egor Dmitriev <egor.dmitriev@alliander.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bare `mlflow` pattern in `.gitignore` (added in #793 / v4.0.0.a17) matches anywhere in the directory tree. Hatchling uses `.gitignore` for VCS-based file exclusion during wheel builds, so `packages/openstef-models/src/openstef_models/integrations/mlflow/` was silently dropped from the built wheel.
This caused `openstef_models.integrations.mlflow` to be unavailable at runtime since a17 — breaking any downstream code that imports `MLFlowStorage`.
Fix
Root-anchor the patterns: `mlflow` → `/mlflow`, `mlflow_artifacts_local` → `/mlflow_artifacts_local`. This limits the match to only the top-level directories (local MLflow data) and no longer excludes the source module.
Also fixes the missing trailing newline.