Open
Conversation
- tauri 2.9.2 -> 2.10.2, tauri-build 2.5.1 -> 2.5.5 - tauri-plugin-deep-link 2.4.5 -> 2.4.7, tauri-plugin-log 2.7.1 -> 2.8.0 - tauri-plugin-updater 2.9.0 -> 2.10.0, tauri-plugin 2.1.1 -> 2.5.3 - tauri-plugin-single-instance 2.3.6 -> 2.4.0, tauri-plugin-opener 2.5.2 -> 2.5.3 - tauri-plugin-fs 2.4.4 -> 2.4.5 - @tauri-apps/api 2.9.0 -> 2.10.1, @tauri-apps/cli 2.9.2 -> 2.10.0 - @tauri-apps/plugin-deep-link 2.4.5 -> 2.4.7, plugin-dialog 2.4.2 -> 2.6.0 - CI workflows: tauri-cli 2.9.2 -> 2.10.0, fix workaround comment to reference #14413 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
📝 WalkthroughWalkthroughThis pull request updates Tauri CLI and related dependencies from version 2.9.2 to 2.10.0 across GitHub Actions workflows, frontend package.json, and Cargo.toml files. Workflow step descriptions are also updated to reference bug Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
@TestFlight build |
Contributor
|
🚀 TestFlight deployment triggered! Check the Actions tab for progress. |
Deploying maple with
|
| Latest commit: |
38a4918
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cfa9fd9d.maple-ca8.pages.dev |
| Branch Preview URL: | https://chore-upgrade-tauri-2-10.maple-ca8.pages.dev |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/mobile-build.yml (1)
46-53:⚠️ Potential issue | 🟠 MajorPin the installed Tauri CLI version, not just command presence.
The cache restore-keys (lines 51–53) use broad fallback prefixes that match any prior cached
cargo-tauribinary, including older versions. The install step (line 121) checks only binary existence withcommand -v, allowing a previously cached v2.9.0 (or other version) to be reused, skipping the fresh install of the required v2.10.0. This causes version drift in CI.The proposed fix verifies the actual installed version matches the required version before skipping reinstall:
Proposed fix
- name: Install Tauri CLI run: | - if ! command -v cargo-tauri &> /dev/null; then - cargo install tauri-cli --version "2.10.0" --locked + REQUIRED_TAURI_CLI="2.10.0" + INSTALLED_TAURI_CLI="$(cargo-tauri --version 2>/dev/null | awk '{print $2}')" + if [ "$INSTALLED_TAURI_CLI" != "$REQUIRED_TAURI_CLI" ]; then + cargo install tauri-cli --version "${REQUIRED_TAURI_CLI}" --locked --force else echo "Tauri CLI already installed" fiThis same pattern appears in 5 other workflows: testflight-on-comment.yml, release.yml, desktop-build.yml, claude.yml, android-build.yml.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/mobile-build.yml around lines 46 - 53, The cache key/restore-keys are too broad and the install step only checks for binary presence, allowing older cached tauri CLI to be reused; update the cache key to include the required version (e.g., append the Tauri CLI version string) and tighten restore-keys accordingly, and change the install guard (the step that currently uses command -v to skip install) to verify the actual installed version by running the CLI version command (e.g., cargo tauri --version or the exact binary used) and compare it to the required version (2.10.0) — if missing or mismatched, run the install; apply the same key/version-check pattern to the other workflows mentioned (testflight-on-comment.yml, release.yml, desktop-build.yml, claude.yml, android-build.yml).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/mobile-build.yml:
- Around line 46-53: The cache key/restore-keys are too broad and the install
step only checks for binary presence, allowing older cached tauri CLI to be
reused; update the cache key to include the required version (e.g., append the
Tauri CLI version string) and tighten restore-keys accordingly, and change the
install guard (the step that currently uses command -v to skip install) to
verify the actual installed version by running the CLI version command (e.g.,
cargo tauri --version or the exact binary used) and compare it to the required
version (2.10.0) — if missing or mismatched, run the install; apply the same
key/version-check pattern to the other workflows mentioned
(testflight-on-comment.yml, release.yml, desktop-build.yml, claude.yml,
android-build.yml).
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
frontend/bun.lockis excluded by!**/*.lockfrontend/src-tauri/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
.github/workflows/android-build.yml.github/workflows/claude.yml.github/workflows/desktop-build.yml.github/workflows/mobile-build.yml.github/workflows/release.yml.github/workflows/testflight-on-comment.ymlfrontend/package.jsonfrontend/src-tauri/Cargo.toml
Contributor
|
✅ TestFlight deployment completed successfully! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades all Tauri dependencies to latest versions.
Rust (Cargo.toml)
tauri2.9.2 -> 2.10.2tauri-build2.5.1 -> 2.5.5tauri-plugin-deep-link2.4.5 -> 2.4.7tauri-plugin-log2.7.1 -> 2.8.0tauri-plugin-updater2.9.0 -> 2.10.0tauri-plugin2.1.1 -> 2.5.3tauri-plugin-single-instance2.3.6 -> 2.4.0tauri-plugin-opener2.5.2 -> 2.5.3tauri-plugin-fs2.4.4 -> 2.4.5JS (package.json)
@tauri-apps/api2.9.0 -> 2.10.1@tauri-apps/cli2.9.2 -> 2.10.0@tauri-apps/plugin-deep-link2.4.5 -> 2.4.7@tauri-apps/plugin-dialog2.4.2 -> 2.6.0@tauri-apps/plugin-fs2.4.4 -> 2.4.5@tauri-apps/plugin-opener2.5.2 -> 2.5.3CI Workflows
tauri-cliinstall version from 2.9.2 to 2.10.0 across all 6 workflowstauri.propertiesworkaround comment to reference actual issue ([bug] Android versionName and versionCode not populated from tauri.conf.json after upgrading to 2.9.2 tauri-apps/tauri#14413), still open as of 2.10.xNotable upstream changes
tauri devnow only watches dependent workspace members (faster rebuilds)Summary by CodeRabbit