[WIP] Add high-level merging class for RADOLAN method#81
Open
cchwala wants to merge 4 commits intoOpenSenseAction:mainfrom
Open
[WIP] Add high-level merging class for RADOLAN method#81cchwala wants to merge 4 commits intoOpenSenseAction:mainfrom
cchwala wants to merge 4 commits intoOpenSenseAction:mainfrom
Conversation
…rid and y_grid to ds
…stments to work. Later, the interpolator could also be cached like in the other merging classes.
…ample notebook (which is a modified version of the existing notebook that did use the low-level functions) Several minor things had to be fixed in the module files. TODO is to check if and how it works when passing CML and gauge or when passing gauges only. There is some logic somewhere that might needs adjustment.
… notebook a few times to see how results change (they do) and results (hexbin plot and metrics) are now the same or very similar to what was there before with the old low-level code notebook. Good!
Member
Author
|
This updated notebook from 030c5cc shows the same metrics as before in this notebook when the old lower-level function was used. The hexbin plot also looks very very similar. This means, it works! But tests need still to be added. |
cchwala
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a class based on
MergeBaseto run the RADOLAN adjustment provided by therh_to_rw()function. As a first pragmatic step, I keeprh_to_rw()as it is and transform the data topd.DataFrameas needed using the already existing functions and/or example code for that, plus some required adaptions.TODO:
MergeRADOLANclass