Add new LogicalDetectionData message to SensorData #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmai
added
FeatureRequest
pmai
added
the
ReadyForCCBReview
Contributor
Author
|
Since no one chimed in until now, marking it as ready for CCB review. However more involvement from sensor modeling group would probably be good (I've posted this PR by order of the SET Level project, where it comes from the sensor modeling side of things). |
|
Output from CCB meeting - 09.12.2020
|
kmeids
removed
the
ReadyForCCBReview
kmeids
reviewed
Jan 27, 2021
kmeids
left a comment
kmeids
left a comment
There was a problem hiding this comment.
Nothing major, just some minor linguistic/comments update
kmeids
reviewed
Jan 28, 2021
kmeids
left a comment
kmeids
left a comment
There was a problem hiding this comment.
Missing one comment update for sensor_id
kmeids
added
ReadyForCCBReview
kmeids
approved these changes
Feb 3, 2021
kmeids
left a comment
kmeids
left a comment
There was a problem hiding this comment.
Approved during the CCB meeting 03.02.2021
|
Results from CCB meeting 03.02.2021
|
PhRosenberger
force-pushed
the
feature/logical-detection-data
branch
from
c3f135c to
657aa49
Compare
LogicalDetectionData provides feature data in the virtual cartesian sensor coordinate system and is therefore suitable for fusion at the feature data level, whereas FeatureData is not. Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Rosenberger, Philipp <rosenberger@fzd.tu-darmstadt.de>
pmai
force-pushed
the
feature/logical-detection-data
branch
from
657aa49 to
ed8433b
Compare
Signed-off-by: Rosenberger, Philipp <rosenberger@fzd.tu-darmstadt.de> Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
pmai
force-pushed
the
feature/logical-detection-data
branch
from
ed8433b to
c3c1df6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogicalDetectionData provides feature data in the virtual cartesian
sensor coordinate system and is therefore suitable for fusion at the
feature data level, whereas FeatureData is not.
Signed-off-by: Pierre R. Mai pmai@pmsf.de
This PR coming from the SETLevel4To5 project is partly related to #367, and tackles the issue that the current
FeatureDatainterface is strictly limited to one physical detector/sensor, since the coordinate system is spherical. This makes it more or less impossible to transport fusioned data, which must necessarily reside in one common coordinate system. The naming also tries to align with DIS 23150 (further alignment might also recommend renaming ofFeatureData, which is however not included in this PR so as to remain backward compatible for now).