Skip to content

Make handling of enums in rules check more robust #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2021
Merged

Make handling of enums in rules check more robust #474

merged 1 commit into from
Feb 11, 2021

Conversation

@pmai
Copy link
Contributor

@pmai pmai commented Feb 6, 2021

Earlier versions of this check erroneously treated the end of an enum
as the end of its enclosing message, leading to problems with nested
enums if they appeared not at the end of its enclosing messages.

Signed-off-by: Pierre R. Mai pmai@pmsf.de

  • My code and comments follow the style guidelines and contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@pmai
Make handling of enums in rules check more robust
9c0331e 
Earlier versions of this check erroneously treated the end of an enum
as the end of its enclosing message, leading to problems with nested
enums if they appeared not at the end of its enclosing messages.

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
@pmai pmai added Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. labels Feb 6, 2021
@pmai pmai added this to the V3.3.0 milestone Feb 6, 2021
@pmai pmai self-assigned this Feb 6, 2021
kmeids
kmeids approved these changes Feb 11, 2021
View reviewed changes
Copy link

@kmeids kmeids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved during the CCB meeting 11.02.2021

@kmeids kmeids added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. labels Feb 11, 2021
@pmai pmai merged commit 45dab98 into master Feb 11, 2021
@pmai pmai deleted the fix/rules-test-enum-handling branch February 11, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmeids kmeids kmeids approved these changes

Assignees

@pmai pmai

Labels

Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.

Projects

None yet

Milestone

V3.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pmai @kmeids