-
Notifications
You must be signed in to change notification settings - Fork 130
Add model_reference attribute to RoadMarking (#874) #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Andreas Rauschert <andreas.rb.rauschert@bmw.de>
thomassedlmayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I don’t think there are any special cases for specific road marking types as discussed in #874. All road marking types must conform to the base dimensions regardless of their type. So the model reference role should be consistently implementable for all types.
My only remark for road marking model placement is that road markings' base objects are positioned differently from other OSI objects: their local z-axis corresponds to how the marking is placed on the xy-plane of the lane (see OSI documentation for more details), rather than pointing upwards as it does for other objects. But as the model reference use is left to the implementer, I guess this just plays a role when you're trying to be consistent (in one way or another) in your model reference implementation.
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
acea108 to
23a700f
Compare
Reference to a related issue in the repository
#874
Add a description
Adding the model_reference attribute to the RoadMarking class.
This was missing and is now consistent with the other classes TrafficLight, MovingObject...
Backward-compatible, as added as optional and at the end (attribute #6).
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!