Skip to content

Conversation

@arauschert
Copy link
Contributor

@arauschert arauschert commented Oct 31, 2025

Reference to a related issue in the repository

#874

Add a description

Adding the model_reference attribute to the RoadMarking class.
This was missing and is now consistent with the other classes TrafficLight, MovingObject...

Backward-compatible, as added as optional and at the end (attribute #6).

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

Signed-off-by: Andreas Rauschert <andreas.rb.rauschert@bmw.de>
@jdsika jdsika added the FeatureRequest Proposals which enhance the interface or add additional features. label Oct 31, 2025
@jdsika jdsika added this to the V3.8.0 milestone Oct 31, 2025
Copy link
Contributor

@thomassedlmayer thomassedlmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don’t think there are any special cases for specific road marking types as discussed in #874. All road marking types must conform to the base dimensions regardless of their type. So the model reference role should be consistently implementable for all types.

My only remark for road marking model placement is that road markings' base objects are positioned differently from other OSI objects: their local z-axis corresponds to how the marking is placed on the xy-plane of the lane (see OSI documentation for more details), rather than pointing upwards as it does for other objects. But as the model reference use is left to the implementer, I guess this just plays a role when you're trying to be consistent (in one way or another) in your model reference implementation.

@pmai pmai added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Nov 5, 2025
@asadekasam asadekasam added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Nov 6, 2025
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
@pmai pmai force-pushed the 874-add-road-marking-model-reference branch from acea108 to 23a700f Compare November 6, 2025 10:42
@pmai pmai merged commit 78b5229 into master Nov 6, 2025
8 checks passed
@pmai pmai deleted the 874-add-road-marking-model-reference branch November 6, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FeatureRequest Proposals which enhance the interface or add additional features. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants