feat: Add @MUBENDIRAN as a contributor #905
Conversation
|
Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @MUBENDIRAN! You're almost to the end of the course! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on submitting your first Pull Request! 🎉
We appreciate your contribution. Feel free to join the conversation in our
Community and say hello!
MUBENDIRAN
left a comment
MUBENDIRAN
left a comment
There was a problem hiding this comment.
How can i know i have contributed to this repo, when my pull request merged or should i do any other promotions
adiati98
left a comment
adiati98
left a comment
There was a problem hiding this comment.
Thanks for your contribution, @MUBENDIRAN! ✨
Based on this bot warning, can you please link your issue in your PR? Just write Closes #904 in the "Linked Issue" section.
Also, answering your question, you want to see your PR get merged. To get your PR get merged, first, a maintainer needs to review your PR. They might ask you for some changes (like what I'm asking you here) or approve it if there's no issue. Then, they will merge your PR. Your PR won't get merge automatically without a maintainer's review. I hope this answers your question.
|
yes thanks |
|
Hii i think i have the Related issues section properly |
MUBENDIRAN
left a comment
MUBENDIRAN
left a comment
There was a problem hiding this comment.
Hii can I know any other changes is needed since I have made the issue number changes in the PR as instructed but still my PR not been merged
|
adiati98
left a comment
adiati98
left a comment
There was a problem hiding this comment.
Thanks for the fix, @MUBENDIRAN! 🚀
Also, please keep in mind that some OSS projects (even the big ones) might have a small team of maintainers. It will take some time for maintainers to review, follow up, and merge a PR. The time for them to handle PRs depend on their workload and capacity, as most of maintainers are volunteers, too. 🙂
If you haven't heard from them, say, within a week, you can ask them about the progress for your PR. I hope this info would be helpful for your journey in open source! ✨
2 participants
Description
This PR adds @MUBENDIRAN as a contributor
What type of PR is this? (check all applicable)
Related Issues
Closes #904
Contributors Checklist
I've read through the Getting Started section
Have you run
npm run contributors:generateto generate your profile and the badge on the README?Added to documentation?
Screenshot (Required for PR Review)
[optional] What GIF best describes this PR or how it makes you feel?