Fix semantic html #1301
Draft
Fix semantic html #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New translations en.yml (Swedish) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Japanese) * New translations en.yml (Basque) * New translations en.yml (German) * New translations en.yml (Basque) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Spanish, Mexico) * New translations en.yml (French, Canada) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Catalan, Algherese) * New translations en.yml (German) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (German) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Turkish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Finnish (plain)) * New translations en.yml (French) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (French, Canada) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Swedish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Catalan, Algherese) * New translations en.yml (Basque) * New translations en.yml (Korean) * New translations en.yml (Vietnamese) * New translations en.yml (Persian) * New translations en.yml (Maltese)
* Error handling of not found resources * Fix Page specs * Add I18n support for not found error * Fix i18n key * Fix locales * Fix failing specs * Add error code token * Rename context from graphQL hidden space to graphQL not found space * Address other review comments
* Refactor API location * Add Proposal answer mutation example * Add link to decidim docs website * Process page announcement bug fix with system test (decidim#15616) Co-authored-by: Leo <leo.storey@mainiotech.fi> * Add debug permissions * Fix exception * Error handling of not found resources * Fix Page specs * Add I18n support for not found error * Fix i18n key * Fix locales * Fix failing specs * Adjust some of the existing mutations * Add error code token * Rename context from graphQL hidden space to graphQL not found space * Address other review comments * Fix typo * Fix some types * Fix failing specs * Fix failing specs * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix NuValidator image * Apply review recommendations * Update decidim-api/lib/decidim/api/test/component_context.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Leo Storey <123873192+Ginger-Leo@users.noreply.github.com> Co-authored-by: Leo <leo.storey@mainiotech.fi> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…5768) * Refactor QueryType to API * Remove bullet error * Remove unneded autoload * Fix typo * Disable bullet * Fix bullet error
* Extract each one spec in own test * Fix budgets specs * Add propsoals specs * Fix failing specs * Update decidim-proposals/spec/system/proposals_breadcrumbs_spec.rb Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update decidim-accountability/spec/system/explore_versions_spec.rb Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Extract results * Extract surveys specs * Extract surveys specs part 2 * Fully extract proposals * Fully extract proposals * Fix typo * Extract meeetings * Extract elections * Extract debates * Extract collaborative texts * Extract blogs * Create uniform specs * Fix filename * Apply review recommendations * Standardize tests * Fix specs --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
* Add AWS Bucket configuration for public assets * Fix typo * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/modules/services/pages/activestorage.adoc * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update docs/modules/services/pages/activestorage.adoc Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> Co-authored-by: Leo <leo.storey@mainiotech.fi>
…decidim#15787) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* condition to display responses in dropdown * i18n transalation for responses * Update decidim-surveys/app/views/decidim/surveys/admin/surveys/index.html.erb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-surveys/config/locales/en.yml Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-surveys/config/locales/en.yml Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * updated the icon for responses tab * route for admin added in spec, specs for responses and no responses added * fixed translation conflict from suggestion --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Leo <leo.storey@mainiotech.fi>
* Refactor API documentation * Fix typos * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Apply more review recommendations * Apply more review recommendations - error pages * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
* Refactor API to raise and catch Decidim::PermissionAction::PermissionNotSetError exceptions * Add Decidim::Api::Errors::MutationNotAuthorizedError * Add Decidim::Api::Errors::ValidationError * Add Decidim::Api::Errors::AttributeValidationError * Refactor API based comments * Adjust specs * Remove unusued locale
* This menu, it should be left aligned and not centered * The height of the search bar and languages is not the same (desktop) * Keep the same margin, 16 pixels (mobile) * Refactor menu * Fix Search box height * Fix specs, run linters * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove important on padding * Refactor selectors * Apply review recommendation * Fix layout * Fix language list width for mobile * Apply review recommendation --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Fix dependabot configuration * chore: bump actions/cache from 4 to 5 Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Revert dependabot config * Patch template to use v5 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove unused content blocks * Remove unused string * Remove addtional cells * Remove metadata references * Cleanup * Update decidim-core/app/views/layouts/decidim/header/_main_links_desktop.html.erb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Fix area-current page in menu breadcrumb * Fix failing specs on schema specs * Last round of cleanup --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Remove sticky header * Apply review recommendations * Fix failing spec on emoji
…m#15955) * Fix for explanation what means a draft and pending initiative * Add specs * Add example for pending initiatives from other participants
* Removed the import proposals checkbox from new import proposal page * Extracted method from budgets to select custom avaliable states from propsosal component * Extracted relevant translations for states in proposal import * Extracted class method to iterate states and custom states through the state object within the class. Updates current collection on new proposal import page * Updated translation of select_states to requested change. * Updated string of keep_answers to requested change of Keep statuses and answers. * Updated locales to reflect new title information regarding selecting states * Updated translation for states title, working in browser * Removed validation for import_proposals as checkbox is not required to submit an import * Updated valid states to pluck custom states from avaliable states in the form class * Removed import proposals check in examples, failing proposals spec suite * Updated propoasls import spec form to check for imports on proposals with multiple states selected.
…#15962) * Enhance security documentation with templates and procedures Added templates for Security Advisory messages and updated security handling procedures. * Correct grammatical errors in security documentation * Refine security advisory instructions for maintainers Clarified internal instructions regarding the handling of security advisories and updates to the metadata. * Clarify update process for Security Advisory metadata * Link back to Security page from Releases page * Apply suggestions from Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add word 'CVEs' to spellcheck exception * Prefer usage of CVEs instead of CVE's Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Prefer usage of CVEs instead of CVE's Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
…ed model (decidim#15950) * add delagate to can_participate on attached_to model in attachment * apply fixes based on pr suggestions
* Show errors outside of the upload modal * Show the required attribute error when it is in the upload button * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Fix can_participate into ParticipatoryProcessStep * Add spec for attachments * Revert "Add spec for attachments" This reverts commit 53b6cd6. * Refactor attachment specs * Update decidim-participatory_processes/spec/system/participatory_process_steps_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…idim into fix/semantic_html
* Add test * Prevent trying to update not editable attachments with links * Modify expected message to a more specific one
* This menu, it should be left aligned and not centered * When you enter a component within a process (for example), the breadcrumb disappears and does not allow you to navigate (mobile) * arrow_link helper should be renamed to better reflect its new behaviour * Change the color of the disable to the one used elsewhere on the website (see reference). * Apply coderabbit's suggestion * Fix header menu * Apply coderabbit recommendations * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix overflow issue * Add jsDoc for header account menu * Apply review recommendations * Apply coderabbit recommendations * Fix linting errors * Apply latest coderabbit suggestions * Add js specs * Fix overflow and click on mobile menu * Running erblint --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
* Test commit * Fixed bug * supporting test for error during attachment. * fixing failing test * removing unnecessary lines in tests * linting * code rabbit suggestions changes * code rabbit fix * linting --------- Co-authored-by: Leo <leo.storey@mainiotech.fi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR replaces meaningless
spantags byptags on different places in the FO.For the upload of documents in creation of proposals, it replaces a
labelby aptag because the label was used for presentation purposes.This PR is based on the audit of Angers city (pages 50, 70, 72, 86 and 101)
📌 Related Issues
📷 Screenshots (optional)