#31 player hangar finalization#60
Draft
paulbrzeski wants to merge 12 commits intofeature/31-player-hangarfrom
Draft
#31 player hangar finalization#60paulbrzeski wants to merge 12 commits intofeature/31-player-hangarfrom
paulbrzeski wants to merge 12 commits intofeature/31-player-hangarfrom
Conversation
paulbrzeski
commented
Dec 31, 2025
| l.mode = 'single_player'; | ||
|
|
||
| l.scenograph.actors.map.get('Player One').setMode('vehicle'); | ||
| l.scenograph.actors.player = l.scenograph.actors.get('Player One'); |
Member
Author
There was a problem hiding this comment.
This should be set in menu logic
paulbrzeski
commented
Dec 31, 2025
| // Set the ship as ready. | ||
| l.current_scene.objects.demoShip.ready = true; | ||
| l.current_scene.objects.demoShip.camera_distance = l.current_scene.objects.demoShip.default_camera_distance + ( l.current_scene.room_depth / 2 ); | ||
| l.current_scene.objects.demoShip.mesh.userData.object.position.x = l.current_scene.objects.demoShip.mesh.position.x; |
Member
Author
There was a problem hiding this comment.
Need to do something about the demo ship, it probably needs to be split off with its own NPC AI so that it can fly around in "demo" mode while the player is in menu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main PR #59 is too large, making new PR to observe finalisation of #31