-
Notifications
You must be signed in to change notification settings - Fork 59
Add ShadowStyle support #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Augment PR SummarySummary: Adds initial 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| key = "OPENSWIFTUI_PRINT_TREE" | ||
| value = "1" | ||
| isEnabled = "YES"> | ||
| isEnabled = "NO"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codebase reads OPENSWIFTUI_PRINT_TREE (e.g. DisplayListViewRenderer/DisplayListViewUpdater), but this scheme now defines SWIFTUI_PRINT_TREE, so enabling it won’t trigger tree printing. Consider aligning the environment variable key (or providing both) so the scheme matches runtime behavior.
Severity: low
Other Locations
Example/Example.xcodeproj/xcshareddata/xcschemes/OSUI_Example.xcscheme:70Example/Example.xcodeproj/xcshareddata/xcschemes/SUI_Example.xcscheme:70Example/Example.xcodeproj/xcshareddata/xcschemes/SUI_HostingExample.xcscheme:57
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
+ Coverage 13.14% 13.17% +0.02%
==========================================
Files 619 619
Lines 36740 36745 +5
==========================================
+ Hits 4831 4840 +9
+ Misses 31909 31905 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add _ShadowEffect as an EnvironmentalModifier with a _Resolved inner type conforming to RendererEffect. Includes View.shadow(color:radius:x:y:) convenience modifier.
* Add ShadowEffect support (#776) Add _ShadowEffect as an EnvironmentalModifier with a _Resolved inner type conforming to RendererEffect. Includes View.shadow(color:radius:x:y:) convenience modifier. * Add ShadowEffectUITests
No description provided.