Skip to content

Add ShadowStyle support#776

Merged
Kyle-Ye merged 4 commits intomainfrom
feature/shadow_style
Feb 8, 2026
Merged

Add ShadowStyle support#776
Kyle-Ye merged 4 commits intomainfrom
feature/shadow_style

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Feb 8, 2026

No description provided.

@github-actions github-actions bot added enhancement New feature or request RenderEffect documentation Improvements or additions to documentation test Test related issue labels Feb 8, 2026
@Kyle-Ye Kyle-Ye merged commit cb84f0a into main Feb 8, 2026
5 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/shadow_style branch February 8, 2026 10:14
@augmentcode
Copy link

augmentcode bot commented Feb 8, 2026

🤖 Augment PR Summary

Summary: Adds initial ShadowStyle support so shape styles can carry drop/inner shadow effects.

API: Documents ShadowStyle.drop/inner and introduces ShapeStyle.shadow(_:) helpers.

Pipeline: _ShadowShapeStyle stores resolved shadow effects in ShapeStyle.Pack.

Rendering: ShapeStyleRendering begins translating style shadow effects into GraphicsFilter.shadow.

Tests: Updates shape snapshot tests and adds a dedicated shadow snapshot case.

Dev tooling: Tweaks Example schemes’ environment variables for print-tree/debug toggles.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

key = "OPENSWIFTUI_PRINT_TREE"
value = "1"
isEnabled = "YES">
isEnabled = "NO">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codebase reads OPENSWIFTUI_PRINT_TREE (e.g. DisplayListViewRenderer/DisplayListViewUpdater), but this scheme now defines SWIFTUI_PRINT_TREE, so enabling it won’t trigger tree printing. Consider aligning the environment variable key (or providing both) so the scheme matches runtime behavior.

Severity: low

Other Locations
  • Example/Example.xcodeproj/xcshareddata/xcschemes/OSUI_Example.xcscheme:70
  • Example/Example.xcodeproj/xcshareddata/xcschemes/SUI_Example.xcscheme:70
  • Example/Example.xcodeproj/xcshareddata/xcschemes/SUI_HostingExample.xcscheme:57

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.17%. Comparing base (89576ec) to head (a512488).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...tUICore/Shape/ShapeStyle/ShapeStyleRendering.swift 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
+ Coverage   13.14%   13.17%   +0.02%     
==========================================
  Files         619      619              
  Lines       36740    36745       +5     
==========================================
+ Hits         4831     4840       +9     
+ Misses      31909    31905       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Kyle-Ye added a commit that referenced this pull request Feb 8, 2026
Add _ShadowEffect as an EnvironmentalModifier with a _Resolved inner
type conforming to RendererEffect. Includes View.shadow(color:radius:x:y:)
convenience modifier.
Kyle-Ye added a commit that referenced this pull request Feb 8, 2026
* Add ShadowEffect support (#776)

Add _ShadowEffect as an EnvironmentalModifier with a _Resolved inner
type conforming to RendererEffect. Includes View.shadow(color:radius:x:y:)
convenience modifier.

* Add ShadowEffectUITests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request RenderEffect test Test related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant