Skip to content

Conversation

@Ndpnt
Copy link
Contributor

@Ndpnt Ndpnt commented Jan 8, 2026

  • NPM publish now happens before pushing to repository to ensures consistency if publish fails
  • Removed CasperWA/push-protected@v2 dependency, use GitHub Rulesets with bypass configuration instead

Ndpnt added 6 commits January 8, 2026 11:15
Do not rely anymore en CasperWA/push-protected
Rely now to GitHub rulesets with bypass for OTA-Release-Bot instead of classic branch protection
This allows the workflow to be tested against a non-main branch by replacing main with the name of the branch that contains the release code under test.
@Ndpnt Ndpnt requested a review from clementbiron January 8, 2026 14:54
Copy link
Member

@clementbiron clementbiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen in sync 🚀

@Ndpnt Ndpnt force-pushed the refactor-release branch 2 times, most recently from 3bcb7e7 to c731ab2 Compare January 8, 2026 15:05
@Ndpnt Ndpnt merged commit 17fdb06 into main Jan 8, 2026
28 checks passed
@Ndpnt Ndpnt deleted the refactor-release branch January 8, 2026 15:10

- name: Create GitHub release
uses: softprops/action-gh-release@v1
uses: softprops/action-gh-release@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For security, as long as GitHub does not provide immutable releases, using the full SHA is the only way to prevent supply chain attacks.

run: |
git commit -m "Clean changelog" CHANGELOG.md
git push origin
git push origin main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 very good hardening to not rely on branch name matching!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants