Fix npm OIDC auth with push trigger #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empirical observation: the workflow succeeds with "on: push" but fails with "on: pull_request_target". This suggests npm's OIDC validation may not support the pull_request subject claim format, though this isn't explicitly documented by npm. This change is safe because `main` is protected and only accepts PR merges (except OTA-Release-bot for automated release commits). The changelog validation logic also prevents accidental releases.
clementbiron
approved these changes
Jan 12, 2026
Member
clementbiron
left a comment
clementbiron
left a comment
There was a problem hiding this comment.
I don't really understand what you're doing, and I think I would need a lot of context and time to do a proper review. I approve to try to get the release working out as soon as possible.
MattiSG
reviewed
Jan 13, 2026
Member
MattiSG
left a comment
MattiSG
left a comment
There was a problem hiding this comment.
This change seems very dangerous to me. I understand that now, the release workflow will be called on every push to main, not anymore on merged pull requests only. How will this broadening of release triggers not create loops when the release workflow creates a commit on main to modify the changelog?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.